Configuration not read correctly in oa_core_user_spaces_render()

When a form element of type options is submitted Drupal will insert a 'key' => 0 entry for options that are left unselected. The function oa_core_user_spaces_render() does not handle this correctly when reading $conf['types'].

In my case $conf['types'] contains the following values when only Spaces are selected:

array(
  'oa_space' => 'oa_space',
  'oa_group' => 0,
);

The loop foreach ($group_types as $type) { also loops over this zero value, invoking oa_core_get_groups_by_user_access() with $type = (int) 0.

This, in turn causes a cache polution because the result of oa_core_get_groups_by_user_access(..., $type = 0) is empty but the cache id $cid used in this function is exactly the same were the oa_core_get_groups_by_user_access() function called without $type parameter. As such, once oa_core_get_groups_by_user_access(..., $type = 0) is called, oa_core_get_groups_by_user_access() will return an empty result even when the user has spaces.

Steps to reproduce:

Requirements:

• devel module
• current user has one or more oa_space memberships

1. Execute the following code in /devel/php: dpm(oa_core_get_groups_by_user_access());
2. Notice that there are results.
3. Clear the cache at /admin/config/development/performance
4. Go to /spaces (this page contains the panel that contains the bug, the cache is now poluted)
5. Execute the following code in /devel/php: dpm(oa_core_get_groups_by_user_access());
6. Notice that there are no results.