How to reproduce:
* Enable l10n_contributor
* Enable address
* (if that matters, update all translations)
* Want to translate Postal code In Context: Address label to german Postleitzahl
* After submit, form error:
Errors while contributing translations:<ul><li>Translation rejected by https://localize.drupal.org/. Reason: <em class="placeholder">Suggested translation already appears as active translation or suggestion.</em></li></ul>
The translation is not saved due to form error.

So we end up with a situation where it is not possible to get the translation into the system without uninstalling l10n_contributor. So setting critical.

Comments

axel.rutz created an issue. See original summary.

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin commented
Issue summary: View changes
bbuchert’s picture

bbuchert CreditAttribution: bbuchert as a volunteer commented

Experiencing the same bug

lukasss’s picture

lukasss CreditAttribution: lukasss as a volunteer commented

I also have this error

kallado’s picture

kallado CreditAttribution: kallado as a volunteer and at JAVALI commented

The problem is that your translation has already been made, you don't have to uninstall the module just uncheck the option "Enable sharing translation modifications with server" in the "Update settings" tab on /admin/config/regional/translate/settings.
But still the module should let the translation to be saved locally.

estoyausente’s picture

estoyausente
Primary language Spanish
CreditAttribution: estoyausente as a volunteer and at Bodeboca for Bodeboca commented

@kallado but I have the same error and it's a problem. Really, I think that the problem is bigger.

If I contribute a translation, the translation doesn't be saved locally (only be shared as a contributed string) and I have to wait the string validation in localize.drupal.org and update my translation to see it.

I think that the expected behavior is save the string locally (to see it) and share it as a contributed string. If the module doesn't work fo this way is completely useless, or only valid for contribution purposes in place of "share the translations free, create a better drupal without and extra effort".

How can we help to fix it?

Thanks

kallado’s picture

kallado CreditAttribution: kallado as a volunteer and at JAVALI commented

@estouyausente "How can we help to fix it?" good question let me know if you find an answer :). I agree with you that even if we share the translation it should still be translated locally (even if it already exists). I looked at the code to try to create a patch at the time but I can't remember why I didn't end up doing it, let me know if you find something.

Thanks

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Active » Closed (duplicate)

Our submission handler runs after the built-in submission handler in the current code. That was fixed 2 years ago in #2919517: l10n_client_contributor doesn't save translation locally. There was no release since then though, so I think that should explain why people reported it later on. I'll tag a new release now to make sure people get it. Please reopen if it still applies to alpha2.