Follow-up to #2865971: Use stylelint as opposed to csslint in core. Configure the number-leading-zero to be consistent with

Relevant coding standard from the CSScomb settings for Drupal:

"leading-zero": true,

Proposed resolution

Brief instructions on running stylelint - you'll need npm...

All the commands below take place in DRUPAL_ROOT/core
To install stylelint

npm install

This will install Drupal 8's npm dependencies of which stylelint is one.

To run it on all core css files. Apply this issue's patch and do the following command from DRUPAL_ROOT/core

npm run lint:css

Remaining tasks

User interface changes


API changes



alexpott created an issue. See original summary.

BrightBold’s picture

Issue summary: View changes
27.38 KB

Removed the number-leading-zero rule from .stylelintrc.json since it matches stylelint-config-standard (per #2866816-9: Update stylelint rule length-zero-no-unit to be consistent with Drupal's CSS standards, thanks idebr) and updated all CSS to pass.

This patch relies on #2865971-44: Use stylelint as opposed to csslint in core so won't pass testing until that is committed.

BrightBold’s picture

Status: Active » Needs review
64.5 KB

Patch for testing purposes which combines the patch in #1 above, plus the patch from #2865971-44: Use stylelint as opposed to csslint in core.

droplet’s picture

Version: 8.3.x-dev » 8.4.x-dev
Status: Needs review » Needs work

Needs reroll

BrightBold’s picture

Assigned: Unassigned » BrightBold
BrightBold’s picture

This is the same as the patch in #1, which seemed like it still applied so let's re-test with 8.4.

BrightBold’s picture

Assigned: BrightBold » Unassigned
BrightBold’s picture

Status: Needs work » Needs review
brahmjeet789’s picture

Hi BrightBold,

i have changed some things in ur patch may be it works .