Reordering of css selectors

Need more info to reproduce this reported issue

$css = '.inner-wrap, .page-body {
  max-width: 80em;
  padding: 0 0.8em;
  margin: 0 auto;
  position: relative;
}

.page-body {
  padding-top: 2.4em;
  padding-bottom: 2.4em;
}';

$output = advagg_load_stylesheet_content($css, TRUE);
echo $output;

.inner-wrap,.page-body{max-width:80em;padding:0 0.8em;margin:0 auto;position:relative;}.page-body{padding-top:2.4em;padding-bottom:2.4em;}

Spliting up CSS was rewritten due to this issue #2852487: advagg_split_css_file() can lead to infinite loop; issue with large css files. (over 5k selectors for a single set of rules).

I'll work on this tomorrow. Only concern is if multiple CSS parts get combined (think media queries). I'll want to test it.

Verified and this works. Found a flaw in advagg_split_css_string where it's dropping the last selector in large rule sets (over the 4k limit). Will work on a solution and hopefully create a test; the test css file will have to be generated as I'm using a 5mb css file for testing currently.

Code used to test

  module_load_include('inc', 'advagg', 'advagg');
  $file_info = array(
    'data' => 'main.css',
  );
  $before = (string) @file_get_contents($file_info['data']);
  $before_selector_count = advagg_count_css_selectors($before);

  $parts = advagg_split_css_file($file_info);
  $after = '';
  foreach ($parts as $part) {
    $after .= "\n" . (string) @file_get_contents($part['data']);
  }
  $after_selector_count = advagg_count_css_selectors($after);

If the selector counts don't match then it messed up.

To check the order diff seems like the only way to do it... which I can do locally but not in an automated way.

  module_load_include('inc', 'advagg', 'advagg');
  $file_info = array(
    'data' => 'main.css',
  );
  $before = (string) @file_get_contents($file_info['data']);
  $before_selector_count = advagg_count_css_selectors($before);

  $parts = advagg_split_css_file($file_info);
  $after = '';
  foreach ($parts as $part) {
    $after .= "\n" . (string) @file_get_contents($part['data']);
  }
  $after_selector_count = advagg_count_css_selectors($after);

  $before = str_replace(', ', ",\n", $before);
  $before = str_replace("\r", "\n", $before);
  $before = str_replace("\n\n", "\n", $before);
  $before = str_replace("} }", "}}\n", $before);
  $before = str_replace("}\n}", "}}\n", $before);
  $before = str_replace("\n \n", "\n", $before);
  $before = str_replace("\n\n", "\n", $before);


  $after = str_replace(', ', ",\n", $after);
  $after = str_replace("\r", "\n", $after);
  $after = str_replace("\n\n", "\n", $after);
  $after = str_replace("} }", "}}\n", $after);
  $after = str_replace("}\n}", "}}\n", $after);
  $after = str_replace("\n \n", "\n", $after);
  $after = str_replace("\n\n", "\n", $after);


  $uuid = uniqid();
  file_put_contents("temporary://before{$uuid}.txt", $before);
  file_put_contents("temporary://after{$uuid}.txt", $after);

  $return = array();
  $temp_dir = DRUPAL_ROOT . '/' . advagg_get_relative_path('temporary://');
  exec("diff -u -U 30 {$temp_dir}/before{$uuid}.txt {$temp_dir}/after{$uuid}.txt", $return);

  unlink("temporary://before{$uuid}.txt");
  unlink("temporary://after{$uuid}.txt");

  print_r($return);

Still need to generate a large css file for testing purposes.

Tests a generated file with 280,028 selectors making sure it gets split correctly.