Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
There are some parts of the code that don't follow the coding standard and need to be modified.
Proposed resolution
Update the code according to the coding standard.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#6 | Screen Shot 2017-04-03 at 6.31.58 PM.png | 12.46 KB | krina.addweb |
#6 | Screen Shot 2017-04-03 at 6.31.46 PM.png | 64.35 KB | krina.addweb |
#5 | unused_variable-2866092-5.patch | 2.66 KB | adriancid |
#4 | Error shown in coder review.png | 25.82 KB | krina.addweb |
#4 | Patch applying in module file.png | 5.72 KB | krina.addweb |
Comments
Comment #2
adriancidComment #3
adriancidComment #4
krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented@adriancid, Thanks for the patch but I found some problem during testing of your patch.
1) When I applied the patch in module file it throws 1 error.PFA
2) When I checked your patch over simplytest.me with the use of coder module it still shows the error in node_revision_delete.batch.inc file. PFA
Comment #5
adriancid@krina.addweb thanks for your feedback.
For the first problem you need to use:
to test the patch, because the error comes from the .info file and once you download the module from drupal.org the site put additional info in this file, and this cause the problem.
The other problem is fixed in this patch.
Comment #6
krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented@adriancid, Thanks for your quick response & for the updated patch. Now it works well & removes the remaining coding standard error. As i checked it manually by applying it in module file & with the use of Coder module over simplytest.me. PFA
Thanks again for your help.
Comment #8
adriancidComment #10
adriancid