Problem/Motivation

There are some parts of the code that don't follow the coding standard and need to be modified.

Proposed resolution

Update the code according to the coding standard.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#6 Screen Shot 2017-04-03 at 6.31.58 PM.png12.46 KBkrina.addweb
#6 Screen Shot 2017-04-03 at 6.31.46 PM.png64.35 KBkrina.addweb
#5 unused_variable-2866092-5.patch2.66 KBadriancid
#4 Error shown in coder review.png25.82 KBkrina.addweb
#4 Patch applying in module file.png5.72 KBkrina.addweb
#3 fix_code_standard_format-2866086-3.patch1.95 KBadriancid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

adriancid created an issue. See original summary.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Title: Fix code standar format » Fix code standard format
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Status: Active » Needs review
FileSize
fix_code_standard_format-2866086-3.patch1.95 KB
krina.addweb’s picture

krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs review » Needs work
FileSize
Patch applying in module file.png5.72 KB
Error shown in coder review.png25.82 KB

@adriancid, Thanks for the patch but I found some problem during testing of your patch.

1) When I applied the patch in module file it throws 1 error.PFA
2) When I checked your patch over simplytest.me with the use of coder module it still shows the error in node_revision_delete.batch.inc file. PFA

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Status: Needs work » Needs review
FileSize
unused_variable-2866092-5.patch2.66 KB

@krina.addweb thanks for your feedback.

For the first problem you need to use:

git clone --branch 7.x-2.x https://git.drupal.org/project/node_revision_delete.git
cd node_revision_delete

to test the patch, because the error comes from the .info file and once you download the module from drupal.org the site put additional info in this file, and this cause the problem.

The other problem is fixed in this patch.

krina.addweb’s picture

krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screen Shot 2017-04-03 at 6.31.46 PM.png64.35 KB
Screen Shot 2017-04-03 at 6.31.58 PM.png12.46 KB

@adriancid, Thanks for your quick response & for the updated patch. Now it works well & removes the remaining coding standard error. As i checked it manually by applying it in module file & with the use of Coder module over simplytest.me. PFA

Thanks again for your help.

  • adriancid committed 4410604 on 7.x-2.x 
    Issue #2866086 by adriancid, krina.addweb: Fix code standard format
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid for Ville de Montréal commented