* @return AjaxResponse
   *   The response object.

This isn't correct. See unflag() in the same class.

CommentFileSizeAuthor
#8 correct-return-type-flag-2864926-8.patch564 bytesshashikant_chauhan
#3 correct-return-type-flag-2864926-3.patch568 bytesmarncz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

_Archy_’s picture

_Archy_ CreditAttribution: _Archy_ at PitechPlus commented
Issue tags: +DCTransylvania
marncz’s picture

marncz CreditAttribution: marncz commented
FileSize
correct-return-type-flag-2864926-3.patch568 bytes
marncz’s picture

marncz CreditAttribution: marncz commented
Status: Active » Needs review
valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald commented
Status: Needs review » Reviewed & tested by the community

@return comment now matches the one of `FieldEntryFormController::getForm()`, so - RTBC

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Reviewed & tested by the community » Needs work

Thanks for the patch!

+++ b/src/Controller/FieldEntryFormController.php
@@ -21,8 +21,8 @@ class FieldEntryFormController extends ControllerBase {
+   *   The processed add form for the given flagging.

Not quite right, as there isn't a flagging that's been given.

I would say just 'The processed form to create the flagging.'

ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
CreditAttribution: ashishdalvi at Iksula, Blisstering Solutions commented
Issue tags: +dcm2017

We will work on it at DCM2017

shashikant_chauhan’s picture

shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer and at Iksula commented
Status: Needs work » Needs review
FileSize
correct-return-type-flag-2864926-8.patch564 bytes

Adding updated patch.

  • joachim committed 7cf4c9f on 8.x-4.x authored by marncz 
    Issue #2864926 by marncz, shashikant_chauhan: Fixed incorrect docs for @...
joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Fixed

Thanks everyone! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean at PitechPlus commented
Issue tags: -DCTransylvania