Problem/Motivation

The revision log should represent an accurate log of which user updated the content at a given time. If a user moderates a piece of content via the moderation form, the revision author is not set so the revision log shows the author of the previous revision. This can be confusing if users are using the log to view moderation comments etc.

Proposed resolution

Set the revision uid in the submission handler

Remaining tasks

Write tests
Write code.

User interface changes

Real representation of user who actioned moderation in revision log.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#4 2864883-revision-author-4.patch3.79 KBacbramley
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

acbramley created an issue. See original summary.

acbramley’s picture

acbramley CreditAttribution: acbramley at PreviousNext for Transport for NSW commented
Issue summary: View changes
acbramley’s picture

acbramley CreditAttribution: acbramley at PreviousNext for Transport for NSW commented
Issue summary: View changes
acbramley’s picture

acbramley CreditAttribution: acbramley at PreviousNext for Transport for NSW commented
Status: Active » Needs review
FileSize
2864883-revision-author-4.patch3.79 KB
fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat at PreviousNext for Transport for NSW commented

This looks good and fixes the bug. There's a few unrelated documentation changes but they're all spot on. RTBC pending green on the test.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat at PreviousNext for Transport for NSW commented
Status: Needs review » Reviewed & tested by the community
drupal-son’s picture

drupal-son CreditAttribution: drupal-son commented

I can confirm the same issue.

It works as expected if the user edits the node and save and move to another state.
But when using the moderation form within the node, it uses the author of the previous revision.

Checking this patch and will provide feedback.

Thanks.

drupal-son’s picture

drupal-son CreditAttribution: drupal-son commented

Confirmed. Path fixed the issue.

  • larowlan committed dfe16bd on 8.x-1.x authored by acbramley 
    Issue #2864883 by acbramley, fenstrat, drupal-son: Moderation form...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

fixed, thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.