The DS configurations are empty on template_preprocess_ds_entity_view and could lead to WOD if no conditional statements there to check if the configurations exits before creating the instance.
Recoverable fatal error: Argument 2 passed to Drupal\\Component\\Plugin\\PluginManagerBase::createInstance() must be of the type array, null given, called in /Users/heshan/Sites/.../modules/contrib/ds/ds.module on line 318

Patch attached.

Files: 
CommentFileSizeAuthor
#9 2864864-patch_1.diff439 bytesheshanlk

Comments

heshanlk created an issue. See original summary.

heshanlk’s picture

Status: Active » Needs review
FileSize
433 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2864864-patch.diff, failed testing.

heshanlk’s picture

FileSize
427 bytes
heshanlk’s picture

Status: Needs work » Needs review
swentel’s picture

Version: 8.x-2.x-dev » 8.x-3.x-dev
Status: Needs review » Needs work
Issue tags: +Needs tests
+++ b/ds.module
@@ -274,6 +274,7 @@ function ds_entity_view_alter(&$build, EntityInterface $entity, EntityDisplayInt
+  if(empty($configuration)) return;

please make sure this is following the coding standards

heshanlk’s picture

Status: Needs work » Needs review
FileSize
439 bytes

Status: Needs review » Needs work

The last submitted patch, 7: 2864864-patch_1.diff, failed testing.

heshanlk’s picture

Status: Needs work » Needs review
FileSize
439 bytes
aspilicious’s picture

Status: Needs review » Closed (cannot reproduce)

#ds_configuration can't be empty... I think this was caused by the failing upgrade path.