Following up on #2860138: Improve instructions for installing D3.js, I found that following the current instructions results in the d3 and highlightjs libraries being downloaded using git, including the .git directory for each library. I ran into a git-related issue with this (unfortunately I can't remember the details) and, given that the git repos themselves are unnecessary for using the Web Profiler module, I propose adjusting the (Composer) instructions to add this to one's composer.json's repositories section:

"d3": {
    "type": "package",
    "package": {
        "name": "d3/d3",
        "version": "v3.5.17",
        "type": "drupal-library",
        "dist": {
            "url": "https://github.com/d3/d3/archive/v3.5.17.zip",
            "type": "zip"
        }
    }
},
"highlightjs": {
    "type": "package",
    "package": {
        "name": "components/highlightjs",
        "version": "9.7.0",
        "type": "drupal-library",
        "dist": {
            "url": "https://github.com/components/highlightjs/archive/9.7.0.zip",
            "type": "zip"
        }
    }
}
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jdleonard created an issue. See original summary.

jdleonard’s picture

lussoluca’s picture

Hi jdleonard,
seems a good idea, could you please provide a patch for this issue?

Thank you

jdleonard’s picture

Status: Active » Needs review
FileSize
4.93 KB

Sure thing. I may have gone a little overboard touching up the Readme... Feel free to reject any changes!

  • lussoluca committed fbafbd4 on 8.x-1.x authored by jdleonard
    Issue #2864828 by jdleonard: Instructions for installing libraries: use...
lussoluca’s picture

Status: Needs review » Fixed

Committed and pushed to 8.x-1.x
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.