Problem/Motivation

If we want to have csslint turned on for core we need to exclude all the files that currently fail. That way we can lint the passing files and not introduce regression. Then as files are fixed we can ensure that no regressions are made to that file.

Basically #1190252: [573] Use csslint as a weapon to beat the crappy CSS out of Drupal core unfortunately didn't manage to fix all the css.

Proposed resolution

Add all currently failing files to the exclude list.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
FileSize
8.47 KB

Output of csslint ./core with this:



csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/misc/print.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/misc/vertical-tabs.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/block/css/block.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/ckeditor/css/ckeditor-iframe.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/ckeditor/css/ckeditor.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/ckeditor/css/plugins/drupalimagecaption/ckeditor.drupalimagecaption.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/ckeditor/tests/modules/css/test.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/color/tests/modules/color_test/themes/color_test_theme/css/colors.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/config_translation/css/config_translation.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/content_moderation/css/entity-moderation-form.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/contextual/css/contextual.theme.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/dblog/css/dblog.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/field_ui/css/field_ui.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/filter/css/filter.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/layout_discovery/layouts/onecol/onecol.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/layout_discovery/layouts/threecol_25_50_25/threecol_25_50_25.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/layout_discovery/layouts/threecol_33_34_33/threecol_33_34_33.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/layout_discovery/layouts/twocol/twocol.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/layout_discovery/layouts/twocol_bricks/twocol_bricks.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/menu_ui/css/menu_ui.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/node/css/node.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/shortcut/css/shortcut.icons.theme.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/align.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/clearfix.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/container-inline.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/details.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/fieldgroup.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/item-list.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/js.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/nowrap.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/position-container.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/reset-appearance.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/resize.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/system-status-counter.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/system-status-report-general-info.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/components/tablesort.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/css/system.diff.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/tests/css/system.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/tests/modules/common_test/common_test.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/tests/modules/common_test/common_test.print.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/tests/modules/layout_test/css/layout-test-2col.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/tests/themes/test_ckeditor_stylesheets_relative/css/yokotsoko.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/system/tests/themes/test_theme/css/collapse.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/taxonomy/css/taxonomy.theme.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/tour/css/tour.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/update/css/update.admin.theme.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/user/css/user.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/user/css/user.icons.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/user/css/user.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/views/css/views.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/views/tests/modules/views_test_data/views_cache.test.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/views_ui/css/views_ui.contextual.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/modules/views_ui/tests/modules/views_ui_test/css/views_ui_test.test.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/Core/Asset/css_test_files/charset.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/Core/Asset/css_test_files/charset.css.optimized.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/Core/Asset/css_test_files/charset_newline.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/Core/Asset/css_test_files/charset_sameline.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/Core/Asset/css_test_files/comment_hacks.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/Core/Asset/css_test_files/comment_hacks.css.optimized.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/Core/Asset/css_test_files/css_input_with_bom.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/Core/Asset/css_test_files/css_input_with_charset.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/Core/Asset/css_test_files/css_subfolder/css_input_with_import.css.optimized.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/Core/Asset/css_test_files/import1.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/tests/Drupal/Tests/Core/Asset/css_test_files/import2.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/base/elements.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/block.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/book.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/breadcrumb.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/contextual.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/demo-block.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/feed-icon.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/field.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/forum.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/help.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/highlighted.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/image-button.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/item-list.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/list-group.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/menu.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/messages.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/page-title.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/pager.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/panel.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/password-suggestions.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/search-form.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/search-results.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/shortcut.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/site-branding.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/tablesort-indicator.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/text-formatted.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/toolbar.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/vertical-tabs.component.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/bartik/css/components/views.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/action-links.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/book-navigation.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/button.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/container-inline.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/details.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/exposed-filters.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/field.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/file.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/forum.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/image-widget.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/indented.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/inline-form.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/item-list.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/link.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/more-link.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/node.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/pager.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/search-results.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/tablesort.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/classy/css/components/ui-dialog.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/base/typography.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/admin-list.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/breadcrumb.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/colors.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/content-header.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/help.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/modules-page.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/node.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/page-title.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/pager.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/panel.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/search-admin-settings.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/system-status-report-counters.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/components/tablesort-indicator.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/layout/layout.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/seven/css/layout/node-add.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/block/block.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/ckeditor/ckeditor-iframe.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/ckeditor/ckeditor.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/ckeditor/plugins/drupalimagecaption/ckeditor.drupalimagecaption.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/config_translation/config_translation.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/contextual/contextual.theme.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/core/print.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/core/vertical-tabs.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/dblog/dblog.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/field_ui/field_ui.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/file/file.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/filter/filter.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/menu_ui/menu_ui.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/node/node.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/shortcut/shortcut.icons.theme.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/align.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/clearfix.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/container-inline.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/details.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/fieldgroup.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/item-list.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/js.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/nowrap.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/position-container.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/reset-appearance.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/resize.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/system-status-counter.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/system-status-report-general-info.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/components/tablesort.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/system/system.diff.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/taxonomy/taxonomy.theme.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/tour/tour.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/update/update.admin.theme.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/user/user.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/user/user.icons.admin.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/user/user.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/views/views.module.css.


csslint: No errors in /Volumes/devdisk/dev/sites/drupal8alt.dev/core/themes/stable/css/views_ui/views_ui.contextual.css.
xjm’s picture

Can we insert some linebreaks?

alexpott’s picture

I tried that but it just didn't work - unfortunately. I tried it with indentation and without.

xjm’s picture

But HEAD has a linebreak somehow?

alexpott’s picture

The linebreak is not effective and we never scan vendor anyway only things in ./core. :(

alexpott’s picture

Reading the csslint made me aware that they support json in the .rc file - yay! So we have a sensible solution.

Same output as before just a more sensible and easier to read file.

alexpott’s picture

There still one css fail with #2 apparently... https://dispatcher.drupalci.org/job/drupal_patches/8478/

alexpott’s picture

Fixed the thing by ignoring the file. Which in this case is correct because this css file only exists for to test css aggregation.

xjm’s picture

+1, that's way more readable.

Mile23’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs followup

I can verify that the patch removes the error messages from csslint locally.

Also it leaves a bunch of errors in 8.4.x, so maybe commit here and then move this issue to 8.4.x.

The trick then is what's the process for remembering that you've excluded files from csslint? So this needs a follow-up where people fix those files.

alexpott’s picture

@Mile23 - where are the warning on on 8.4.x? https://dispatcher.drupalci.org/job/drupal_patches/8526/ looks fine to me.

Mile23’s picture

Maybe it was something unique to my local... Can't reproduce it now.

lauriii’s picture

Status: Reviewed & tested by the community » Needs review

Should we also consider excluding core/node_modules?

alexpott’s picture

Category: Plan » Task
Issue tags: -Needs followup
FileSize
328 bytes
12.5 KB

No harm in adding that location. Whilst it doesn't exist now and never will be checked in the reason for adding it to .gitignore is the same here. Whilst not in scope to fix the actual issue at hand there is no harm at all in adding it now.

removing needs followup tag because this was introduced in #11 and that's been resolved. #1190252: [573] Use csslint as a weapon to beat the crappy CSS out of Drupal core is the real followup to this issue.

Mile23’s picture

For core, the testbot is saying csslint --format=checkstyle-xml --config=.csslint .

Comment #2 says csslint ./core

Should the testbot only lint core/?

Aside: The drupalci csslint task doesn't seem to leave a lot of evidence of what it did in either the console or the artifacts.

alexpott’s picture

@Mile23 yep we should definitely only lint ./core - no other css should be linted as part of a core run.

Mile23’s picture

Mixologic’s picture

.csslintrc does take a json format, but I think it would be preferable to stick with the original text based format because I *think* that it will allow for comments where I know json does not. For readability, we can just continue the pattern thats there now, namely with each exclude dir on its own line followed by a comma.

A comment as to why we're excluding these files would also be nice (provided that Im correct in thinking we can actually do that). Otherwise LGTM.

alexpott’s picture

@Mixologic unfortunately that means the entire list of files needs to be on one line. See earlier comments on this issue.

Mixologic’s picture

Im not sure what issues you were having in #6 but linebreak does seem to work for me.

I put a comment in just to see how it would work, and, well, they're a little hacky. If you add a comma after the comment it works. otherwise it confuses the next exclude file. So they arent really comments per se, but just slip through because they dont match anything. So It doesnt really seem that "ability to comment" is a feature of the plaintext config file.

I would still prefer to use the non-json version as we're going to want contrib to use their own csslint files, and a hand edited json file can be harder to maintain, and We'll end up getting questions on how to exclude files from testing, so there is a little bit of support burden avoidance baked into my desires.

This is the output I get with this patch:

csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/misc/print.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/misc/vertical-tabs.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/block/css/block.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/ckeditor/css/ckeditor-iframe.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/ckeditor/css/ckeditor.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/ckeditor/css/plugins/drupalimagecaption/ckeditor.drupalimagecaption.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/ckeditor/tests/modules/css/test.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/color/tests/modules/color_test/themes/color_test_theme/css/colors.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/config_translation/css/config_translation.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/content_moderation/css/entity-moderation-form.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/contextual/css/contextual.theme.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/dblog/css/dblog.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/field_ui/css/field_ui.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/filter/css/filter.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/layout_discovery/layouts/onecol/onecol.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/layout_discovery/layouts/threecol_25_50_25/threecol_25_50_25.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/layout_discovery/layouts/threecol_33_34_33/threecol_33_34_33.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/layout_discovery/layouts/twocol/twocol.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/layout_discovery/layouts/twocol_bricks/twocol_bricks.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/menu_ui/css/menu_ui.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/node/css/node.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/shortcut/css/shortcut.icons.theme.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/align.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/clearfix.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/container-inline.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/details.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/fieldgroup.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/item-list.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/js.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/nowrap.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/position-container.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/reset-appearance.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/resize.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/system-status-counter.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/system-status-report-general-info.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/components/tablesort.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/css/system.diff.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/tests/css/system.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/tests/modules/common_test/common_test.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/tests/modules/common_test/common_test.print.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/tests/modules/layout_test/css/layout-test-2col.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/tests/themes/test_ckeditor_stylesheets_relative/css/yokotsoko.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/system/tests/themes/test_theme/css/collapse.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/taxonomy/css/taxonomy.theme.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/tour/css/tour.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/update/css/update.admin.theme.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/user/css/user.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/user/css/user.icons.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/user/css/user.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/views/css/views.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/views/tests/modules/views_test_data/views_cache.test.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/views_ui/css/views_ui.contextual.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/modules/views_ui/tests/modules/views_ui_test/css/views_ui_test.test.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/tests/Drupal/Tests/Core/Asset/css_test_files/charset.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/tests/Drupal/Tests/Core/Asset/css_test_files/charset.css.optimized.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/tests/Drupal/Tests/Core/Asset/css_test_files/charset_newline.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/tests/Drupal/Tests/Core/Asset/css_test_files/charset_sameline.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/tests/Drupal/Tests/Core/Asset/css_test_files/comment_hacks.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/tests/Drupal/Tests/Core/Asset/css_test_files/comment_hacks.css.optimized.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/tests/Drupal/Tests/Core/Asset/css_test_files/css_input_with_charset.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/tests/Drupal/Tests/Core/Asset/css_test_files/css_subfolder/css_input_with_import.css.optimized.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/tests/Drupal/Tests/Core/Asset/css_test_files/import1.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/tests/Drupal/Tests/Core/Asset/css_test_files/import2.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/base/elements.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/block.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/book.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/breadcrumb.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/contextual.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/demo-block.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/feed-icon.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/field.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/forum.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/help.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/highlighted.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/image-button.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/item-list.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/list-group.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/menu.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/messages.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/page-title.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/pager.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/panel.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/password-suggestions.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/search-form.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/search-results.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/shortcut.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/site-branding.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/tablesort-indicator.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/text-formatted.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/toolbar.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/vertical-tabs.component.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/bartik/css/components/views.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/action-links.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/book-navigation.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/button.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/container-inline.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/details.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/exposed-filters.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/field.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/file.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/forum.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/image-widget.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/indented.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/inline-form.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/item-list.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/link.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/more-link.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/node.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/pager.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/search-results.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/tablesort.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/classy/css/components/ui-dialog.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/base/typography.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/admin-list.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/breadcrumb.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/colors.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/content-header.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/help.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/modules-page.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/node.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/page-title.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/pager.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/panel.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/search-admin-settings.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/system-status-report-counters.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/components/tablesort-indicator.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/layout/layout.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/seven/css/layout/node-add.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/block/block.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/ckeditor/ckeditor-iframe.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/ckeditor/ckeditor.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/ckeditor/plugins/drupalimagecaption/ckeditor.drupalimagecaption.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/config_translation/config_translation.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/contextual/contextual.theme.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/core/print.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/core/vertical-tabs.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/dblog/dblog.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/field_ui/field_ui.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/file/file.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/filter/filter.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/menu_ui/menu_ui.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/node/node.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/shortcut/shortcut.icons.theme.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/align.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/clearfix.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/container-inline.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/details.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/fieldgroup.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/item-list.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/js.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/nowrap.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/position-container.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/reset-appearance.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/resize.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/system-status-counter.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/system-status-report-general-info.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/components/tablesort.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/system/system.diff.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/taxonomy/taxonomy.theme.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/tour/tour.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/update/update.admin.theme.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/user/user.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/user/user.icons.admin.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/user/user.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/views/views.module.css.


csslint: No errors in /Users/Ryan/Documents/Work/Current/DrupalAssociation/drupal_core/drupal_8/core/themes/stable/css/views_ui/views_ui.contextual.css.
alexpott’s picture

Well json validates and plain-text doesn't :) But this looks great to me. Less change as well. Testing locally and can confirm it works for me.

I think the comment whilst weird is okay and more helpful than not having one.

alexpott’s picture

joelpittet’s picture

Status: Needs review » Postponed

Let's wait till #2865971: Use stylelint as opposed to csslint in core is resolved before making more work for ourselves

alexpott’s picture

@joelpittet it would great to have your +1 on #2865971: Use stylelint as opposed to csslint in core

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

Status: Postponed » Closed (won't fix)

Closing, running with stylelint