Exception when adding contextual filter [#2864346]

**TROUBLESHOOTING**
* If your menu children aren't showing up, check the following
- Are you providing the correct parent ID in your contextual filter? The
simplest way to do this is to select:
"Provide default value" -> "Content ID from URL"

But when I do that, I get
Drupal\Core\Database\IntegrityConstraintViolationException: SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'nid' in where clause is ambiguous: SELECT node.nid AS node_nid, node_field_data.nid AS nid FROM {node_field_data} node_field_data INNER JOIN {node} node ON node_field_data.nid = node.nid WHERE (( (nid IN (:node_menu_children_filter__0)) )AND(( (node_field_data.status = :db_condition_placeholder_0) ))); Array ( [:db_condition_placeholder_0] => 1 [:node_menu_children_filter__0] => 18 ) in Drupal\Core\Database\Connection->handleQueryException() (regel 668 van /core/lib/Drupal/Core/Database/Connection.php).

I haven't sorted on weight or anything.

If I have no contextual filter, all nodes are showing (offcourse).

Comment	File	Size	Author
#6	2864346-change-reference-to-table.patch	695 bytes	jeremygrajales
#6
#4	views.view_.first_level_menu.yml	9.75 KB	fotograafinge

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

27 March 2017 at 13:39

fotograafinge created an issue. See original summary.

Comment #2

bmcclure CreditAttribution: bmcclure as a volunteer and at Top Floor commented 27 March 2017 at 14:56

Hmm, I definitely see the problem with the query, but I'm not positive where it comes from yet. Could you export your view (or a simplified one if it relies on a lot of other things) and add post the .yml? Or if it's a really simple view, could you post reproduction steps from a scratch? Thanks!

Comment #3

bmcclure CreditAttribution: bmcclure as a volunteer and at Top Floor commented 27 March 2017 at 14:56

Assigned:

Unassigned

» bmcclure

Comment #4

fotograafinge CreditAttribution: fotograafinge commented 28 March 2017 at 06:32

File	Size
views.view_.first_level_menu.yml	9.75 KB

Just a real simple view.

An unsorted list of fields, no filters, no relations, nothing special.

Comment #5

jeremygrajales CreditAttribution: jeremygrajales commented 28 March 2017 at 21:04

I'm also seeing this issue.
If my view is using fields and I only list the "title" of the node, everything returns fine.

In my case, I need the path alias of the node as well. Adding this field results in the same exception from OP.

Comment #6

jeremygrajales CreditAttribution: jeremygrajales commented 28 March 2017 at 21:25

File	Size
2864346-change-reference-to-table.patch	695 bytes

This patch works for me

Comment #7

fotograafinge CreditAttribution: fotograafinge commented 29 March 2017 at 09:10

thx @jeremygrajales, that patch solves the problem !!
the patch from #6 works for me too

Comment #8

jeremygrajales CreditAttribution: jeremygrajales commented 29 March 2017 at 20:01

It only works if you're using a node field in your view (which is most cases where you would run into this issue).

If you're using just the title field, Drupal doesn't do a join on the node table and this patch will cause another exception.
I don't have a lot of exp. with Views API, so maybe someone can find a better solution?

Comment #9

bmcclure CreditAttribution: bmcclure as a volunteer and at Top Floor commented 30 March 2017 at 00:08

Thanks for the patch! This problem hadn't appeared for me because I usually use rendered entities in my views.

That little snippet of code that defaults to "nid" if there's no table alias, I think a better solution for that might be needed altogether. It doesn't seem like that should be needed, but when I was testing originally there was not always a table alias specified. I feel like there should be a better solution for assigning the name to that field in the query, however, that doesn't involve a conditional at all.

I may not have time to look more into this until next week, finishing up a big project at the moment, however if anyone else finds a solution to that before me (or finds that I'm wrong and we need that conditional after all), that'd be great as well.