FieldBlock module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#4 2864264-4.patch1.43 KBbhanuprakashnani
#2 2864264-2.patch1.43 KBPavan B S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
FileSize
2864264-2.patch1.43 KB

Applying the patch, please review

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan at LimoenGroen commented
Status: Needs review » Needs work

Patch does not apply.

bhanuprakashnani’s picture

bhanuprakashnani CreditAttribution: bhanuprakashnani at Google Summer of Code commented
Status: Needs work » Needs review
FileSize
2864264-4.patch1.43 KB

I changed the code according to the new standards. I had a doubt whether to change the arrays like is_array() to is_[] or not. The normal arrays are changed. Please let me know. I ll learn how to do it accordingly. Thank you. Please review it and mention if any more changes are to be made.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec as a volunteer and at Agiledrop - Your Trusted Drupal Teammates commented
Status: Needs review » Reviewed & tested by the community

Tested your patch and it's looking good, short array syntax is used.

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan at LimoenGroen commented

@bhanuprakashnani, no need to make this change. But to learn, I advise you to try to replace is_array() with is_[] and as yourself what the difference is and why the code breaks. Or write a simple two line code that uses is_array() and perform the replacement there. You will learn some PHP along the way.

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan at LimoenGroen commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.