Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Follow-up to #2831116: Coding Standards
-
+++ b/chosen.admin.inc @@ -13,7 +13,10 @@ function chosen_admin_settings($form, &$form_state) { drupal_set_message(t('The library could not be detected. You need to download the !chosen and extract the entire contents of the archive into the %path directory on your server.', - array('!chosen' => l(t('Chosen JavaScript file'), CHOSEN_WEBSITE_URL), '%path' => 'sites/all/libraries') + array( + '!chosen' => l(t('Chosen JavaScript file'), CHOSEN_WEBSITE_URL), + '%path' => 'sites/all/libraries', + )
This is an incorrect fix. l() must not used here.
-
+++ b/chosen.install @@ -12,13 +12,15 @@ function chosen_requirements($phase) { + 'description' => $t('You need to download the !chosen and extract the entire contents of the archive into the %path directory on your server.', array( + '!chosen' => l($t('Chosen JavaScript file'), CHOSEN_WEBSITE_URL),
Same bug again
Comment | File | Size | Author |
---|---|---|---|
#4 | fix-incorrect-translation-2864120-4.patch | 1.77 KB | nagy.balint |
Comments
Comment #2
nagy.balint CreditAttribution: nagy.balint commentedThanks for the report.
Of course that l function was there before, the coding standard patch only changed the formatting and such.
Comment #3
nagy.balint CreditAttribution: nagy.balint commentedThis is likely the reason why this is bad:
https://www.drupal.org/node/322774
As the "Chosen JavaScript file" in the current implementation is not translatable together with the whole sentence, only separately.
Of course this also means that the markup for the link has to enter the string and wont be rendered by Drupal, but its likely the smaller problem.
So the fix is likely something like:
Comment #4
nagy.balint CreditAttribution: nagy.balint at Agence Inovae commentedComment #5
hass CreditAttribution: hass commentedThat is correct.
Comment #7
nagy.balint CreditAttribution: nagy.balint at Agence Inovae commented