The testbot is able to check the codebase for coding standards, so review them and improve the code.

As of 12/19/2017 there are 892 coding standards messages in the 7.x-1.x branch tests.

CommentFileSizeAuthor
#13 metatag-n2864078-13.patch109.41 KBDamienMcKenna
#10 metatag-n2864078-10.patch109.72 KBDamienMcKenna
#7 metatag-n2864078-7.interdiff.txt93.4 KBDamienMcKenna
#7 metatag-n2864078-7.patch125.83 KBDamienMcKenna
#2 metatag-n2864078-2.patch45.02 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
metatag-n2864078-2.patch45.02 KB

WIP.

Status: Needs review » Needs work

The last submitted patch, 2: metatag-n2864078-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Issue summary: View changes
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2891956: Plan for Metatag 7.x-1.23 release
Related issues: +#2931744: Fix tests for the 7.x-1.x branch, testXssMetatagConfig has a regression
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

#2 gets it down to 373 coding standards messages.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2864078-7.patch125.83 KB
metatag-n2864078-7.interdiff.txt93.4 KB

Moar changes, this time using phpcbf.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

And now 514 coding standards messages. Moo.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: #2891956: Plan for Metatag 7.x-1.23 release »
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
metatag-n2864078-10.patch109.72 KB

This is what phpcbf gives, along with a few manual improvements.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2891956: Plan for Metatag 7.x-1.23 release

Status: Needs review » Needs work

The last submitted patch, 10: metatag-n2864078-10.patch, failed testing. View results

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2864078-13.patch109.41 KB

Lets try that again.

  • DamienMcKenna committed 7fa3230 on 7.x-1.x 
    Issue #2864078 by DamienMcKenna: Improve coding standards on Metatags 7....
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

As of the patch in #13 we're down from 934 to 607 coding standards messages, this is good for now.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.