Problem/Motivation

File sites/default/default.settings.php has extra whitespace in the beginning of $databases declaration.

Proposed resolution

Remove the extra whitespace.

CommentFileSizeAuthor
#2 remove_extra_whitespace-2863941-2.patch329 bytesel7cosmos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

el7cosmos created an issue. See original summary.

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
CreditAttribution: el7cosmos as a volunteer and commented
FileSize
remove_extra_whitespace-2863941-2.patch329 bytes
el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
CreditAttribution: el7cosmos as a volunteer and at Alterra commented
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Reviewed & tested by the community

Looks like a good change to me. Patch applies cleanly.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Druid commented
Status: Reviewed & tested by the community » Fixed

The reason why our coding standard tests haven't caught this is that at the moment, default.settings.php is not being tested against phpcs rules. However, while reviewing this I tried to run the phpcs tests manually but this wasn't still caught by our current rules. I filed a bug report for that #2868081: Line indentation not tested for the first non-comment line.

I also noticed that default.settings.php has still inconsistent usage of the different array syntaxes. I also opened an issue for that: #2868078: Use new array syntax in PHP files outside of /core..

Committed daced6f and pushed to 8.4.x. Thanks!

  • lauriii committed daced6f on 8.4.x 
    Issue #2863941 by el7cosmos: Remove extra whitespace in default.settings...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.