Coding standards problems in Schema.php

+++ b/core/lib/Drupal/Core/Database/Schema.php
@@ -29,16 +31,26 @@
-  public function __construct($connection) {
...
+  public function __construct(Connection $connection) {

If you change the methods parameter definition, you must do the same to all method from the classes that inherit from this class. So the MySQL, PostgreSQL and SQLite versions of Schema. If you do that then you can also add inherit docblocks where needed. ;-)

Forget about the inherit docblock. You have created #2863750: Add inheritdoc function doc comment to schema classes for that.

I think that it is better to remove the parameter type hints, they are a BC-break. We can do them in Drupal 9.0. Feel free to make a new issue for that. You can have the parameter type hints in the docblocks. Conclusion: remove the parameter type hints in the methods and not the docblocks and the patch will be RTBC.

I've added a patch based on @adriancid patch adding the changes suggested by @daffie

Thank you for your work on cleaning up Drupal core's code style!

In order to fix core coding standards in a maintainable way, all our coding standards issues should be done on a per-rule basis across all of core, rather than fixing standards in individual modules or files. We should also separate fixes where we need to write new documentation from fixes where we need to correct existing standards. This all should be done as part of #2571965: [meta] Fix PHP coding standards in core. A good place to start is the child issues of #2572645: [Meta] Fix 'Drupal.Commenting.FunctionComment' coding standard.

For background information on why we usually will not commit coding standards fixes that aren't scoped in that way, see the core issue scope guidelines, especially the note about coding standards cleanups. That document also includes numerous suggestions for scoping issues including documentation coding standards cleanups.

Contributing to the overall plan above will help ensure that your fixes for core's coding standards remain in core the long term.

After applying the 'coding_standards_problems_in_schema-2863877-7.patch' patch and running phpcs again, I still found some mistakes.

phpcs --standard=Drupal core/lib/Drupal/Core/Database/Schema.php

FILE: ...ogestag/temp/drupal/core/lib/Drupal/Core/Database/Schema.php
----------------------------------------------------------------------
FOUND 13 ERRORS AFFECTING 11 LINES
----------------------------------------------------------------------
53 | ERROR | Type hint "\Drupal\Core\Database\Connection" missing
| | for $connection
406 | ERROR | Type hint "array" missing for $fields
435 | ERROR | Type hint "array" missing for $fields
468 | ERROR | Parameter tags must be grouped together in a doc
| | comment
468 | ERROR | Tags must be grouped together in a doc comment
482 | ERROR | Tags must be grouped together in a doc comment
498 | ERROR | Tags must be grouped together in a doc comment
513 | ERROR | Type hint "array" missing for $fields
551 | ERROR | Tags must be grouped together in a doc comment
556 | ERROR | Tags must be grouped together in a doc comment
596 | ERROR | Type hint "array" missing for $spec
596 | ERROR | Type hint "array" missing for $keys_new
631 | ERROR | Type hint "array" missing for $fields
----------------------------------------------------------------------

Time: 170ms; Memory: 11.5Mb

Sorry. I tested the patch before reading cilefen comment.

This work is now being done by sniff. The work here is now in #3207949: Fix Drupal.Commenting.FunctionComment.MissingParamType so closing this as a duplicate. I've identified credit to add over there, let me know if I got it wrong.