Problem/Motivation

It would be a useful feature if field group would provide option for setting field group label classes at least.

Proposed resolution

Add a new setting for config form and use it on render.

Remaining tasks

Provide a patch.

User interface changes

New "label_element_classes" option on settings from which is used at form group render.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

huzooka created an issue. See original summary.

huzooka’s picture

Assigned: huzooka » Unassigned
Status: Active » Needs review
FileSize
5.52 KB
huzooka’s picture

Wrong variable used for adding the collabsible class.

huzooka’s picture

Issue summary: View changes
John Pitcairn’s picture

Just what I needed, when I needed it, thanks. Works well, I'm not seeing any issues. I guess we need to wait for the branch to pass and tests to run before marking this RTBC?

John Pitcairn’s picture

Patch no longer applies to 8.x-1.x-dev

John Pitcairn’s picture

Patch re-rolled to remove the section patching the $element['##attributes']['class'][] double hash typo that has already been fixed in dev. No other changes.

darvanen’s picture

Status: Needs review » Needs work

Drupal code standards require new line at end of files.

My bad, patch inserts the newline.

darvanen’s picture

Version: 8.x-1.x-dev » 8.x-3.x-dev
Status: Needs work » Reviewed & tested by the community

Applies cleanly to 8.x-3.x, works well and code is good.

Recommend commit ASAP.

Test failures are unrelated to this patch.

leymannx’s picture

Please merge this feature soon. Nearly same time as the last comment somebody started to build its own module for that: https://www.drupal.org/project/projectapplications/issues/2973303

dercheffe’s picture

+1 please commit it :)

nils.destoop’s picture

Status: Reviewed & tested by the community » Fixed

Thx for the patch. I committed it to dev, and also added some testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.