When editing a promotion and adding conditions, the weight field comes in when adding more values as exposed, and doesn't work right. This because the widgets do not return an element which extends the passed in element array.

CommentFileSizeAuthor
#4 plugin_select_widgets-2863805-4.patch3.79 KBmglaman
#3 promo-with-fix.gif205.94 KBmglaman
#3 plugin_select_widgets-2863805-3.patch3.41 KBmglaman
promo-without-fix.gif100.42 KBmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for LivePerson, Inc commented

And I just checked, it's like a random clone of _weight, not even the one being used.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for LivePerson, Inc commented
Status: Active » Needs review
FileSize
plugin_select_widgets-2863805-3.patch3.41 KB
promo-with-fix.gif205.94 KB

PR: https://github.com/drupalcommerce/commerce/pull/693. Followed approach by IEF, where element is wrapped in a container in widget. Fixes issue.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for LivePerson, Inc commented
FileSize
plugin_select_widgets-2863805-4.patch3.79 KB

Updated patch. This caused single value to not submit.

  • bojanz committed 9bc560f on 8.x-2.x authored by mglaman 
    Issue #2863805 by mglaman: Plugin select widgets show weight field...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Yay

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.