Problem
When system generates context it switches users and invokes hook_logout and hook_login. If there is a SSO module which performs redirect on hook_logout then context generation process will be broken.

Proposed solution
Provide "Silent user switching" setting on provider settings form which will avoid invokation of listed above hooks.

CommentFileSizeAuthor
#10 interdiff-8-10.diff1023 bytesLoparev
#10 tmgmt_smartling-sso_compatability-2863564-10.diff8.95 KBLoparev
#9 interdiff-6-8.diff1.67 KBLoparev
#9 tmgmt_smartling-sso_compatability-2863564-8.diff8.93 KBLoparev
#7 interdiff-6-7.diff1.48 KBLoparev
#7 tmgmt_smartling-sso_compatability-2863564-7.diff9.36 KBLoparev
#6 interdiff-2-6.diff3.87 KBLoparev
#6 tmgmt_smartling-sso_compatability-2863564-6.diff9.35 KBLoparev
#2 tmgmt_smartling-sso_compatability-2863564-2.diff8.58 KBLoparev
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Loparev created an issue. See original summary.

Loparev’s picture

Loparev CreditAttribution: Loparev commented
Status: Active » Needs review
FileSize
tmgmt_smartling-sso_compatability-2863564-2.diff8.58 KB

Here is a patch.

What I've tested:
1. Context debug form:
+ 1.1. Silent switching is off: hooks are invoked - ok
+ 1.2. Silent switching is on: hooks aren't invoked - ok

2. Send context action:
+ 2.1. Silent switching is off: hooks are invoked - ok
+/- 2.2. Silent switching is on: hooks aren't invoked - ok, but there was no context in Smartling dashboard (in recent log messages was message "Context upload for file @file completed successfully."). I think it's problem with context service.

3. Queue worker send context action:
+ 3.1. Silent switching is off: hooks are invoked - ok
+ 3.2. Silent switching is on: hooks aren't invoked - ok

Loparev’s picture

Loparev CreditAttribution: Loparev commented

Tested 2.2 once again - everything is ok.

Soul88’s picture

Soul88
Primary language Ukrainian
Location Ukraine
CreditAttribution: Soul88 at Smartling, Inc commented 
  1. +++ b/src/Form/SendContextActionApproveForm.php
@@ -222,7 +222,8 @@ class SendContextActionApproveForm extends ConfirmFormBase {
+    $context_silent_user_switching = \Drupal::config('tmgmt.translator.smartling')->get('settings.context_silent_user_switching');

    This way we retrieve username only from the first "Smartling" provider 

  2. +++ b/src/SmartlingTranslatorUi.php
@@ -71,6 +71,14 @@ class SmartlingTranslatorUi extends TranslatorPluginUiBase {
+      '#title' => t('Switch users without invocation of "hook_logout" and "hook_login"'),

    Title: Context silent user authentication 

  3. +++ b/src/SmartlingTranslatorUi.php
@@ -71,6 +71,14 @@ class SmartlingTranslatorUi extends TranslatorPluginUiBase {
+      '#description' => t('When system generates context it switches current user with a user from "Username for context retrieval" setting. Then it invokes "hook_logout" and "hook_login". If there is a SSO module in your Drupal installation which performs redirect on "hook_logout" then most probably you should enable this option.'),

    Description: "If checked, Smartling won't trigger hook_login and hook_logout during user authentication for retrieving context."

Soul88’s picture

Soul88
Primary language Ukrainian
Location Ukraine
CreditAttribution: Soul88 at Smartling, Inc commented 
  1. +++ b/src/Context/ContextUserAuth.php
@@ -102,13 +103,13 @@ class ContextUserAuth {
+   * @return \Symfony\Component\HttpFoundation\RedirectResponse A redirect response object.
+   * A redirect response object.

    "A redirect response object." string duplication 

  2. +++ b/src/Form/SendContextActionApproveForm.php
@@ -222,7 +222,8 @@ class SendContextActionApproveForm extends ConfirmFormBase {
+    $context_silent_user_switching = \Drupal::config('tmgmt.translator.smartling')->get('settings.context_silent_user_switching');

    If we retrieve settings this way, they will always come from the "main" Smartling translation provider.

Loparev’s picture

Loparev CreditAttribution: Loparev commented
FileSize
tmgmt_smartling-sso_compatability-2863564-6.diff9.35 KB
interdiff-2-6.diff3.87 KB
Loparev’s picture

Loparev CreditAttribution: Loparev commented
FileSize
tmgmt_smartling-sso_compatability-2863564-7.diff9.36 KB
interdiff-6-7.diff1.48 KB
Loparev’s picture

Loparev CreditAttribution: Loparev commented
Loparev’s picture

Loparev CreditAttribution: Loparev commented
FileSize
tmgmt_smartling-sso_compatability-2863564-8.diff8.93 KB
interdiff-6-8.diff1.67 KB
Loparev’s picture

Loparev CreditAttribution: Loparev commented
FileSize
tmgmt_smartling-sso_compatability-2863564-10.diff8.95 KB
interdiff-8-10.diff1023 bytes
Soul88’s picture

Soul88
Primary language Ukrainian
Location Ukraine
CreditAttribution: Soul88 at Smartling, Inc commented
Status: Needs review » Reviewed & tested by the community

Looks good

  • Loparev committed c0895d7 on 8.x-1.x 
    Issue #2863564 by Loparev: Add compatability with SSO modules
Soul88’s picture

Soul88
Primary language Ukrainian
Location Ukraine
CreditAttribution: Soul88 at Smartling, Inc commented
Status: Reviewed & tested by the community » Fixed

  • Loparev committed c0895d7 on 8.x-2.x 
    Issue #2863564 by Loparev: Add compatability with SSO modules

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.