Cron currently logs its results as notices:

    $this->logger->notice('Cron run completed.');
        $logger->notice('Starting execution of @module_cron().', [
        $logger->notice('Starting execution of @module_cron(), execution of @module_previous_cron() took @time.', [
      $logger->notice('Execution of @module_previous_cron() took @time.', [

The RFC says this is for "significant" conditions (Wikipedia says "events that are unusual but not error conditions").

I think the Informational level would be more appropriate here, since the cron run is a routine event that doesn't normally require attention.

CommentFileSizeAuthor
#13 drupal-cron-2863464-13.patch1.63 KBefpapado
#9 drupal-cron-2863464-9.patch493 bytesefpapado
#2 drupal-cron-2863464-2.patch1.97 KBcburschka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cburschka created an issue. See original summary.

cburschka’s picture

cburschka
they
CreditAttribution: cburschka at PwC's Experience Center commented
Issue summary: View changes
Status: Active » Needs review
FileSize
drupal-cron-2863464-2.patch1.97 KB

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

efpapado’s picture

efpapado CreditAttribution: efpapado as a volunteer commented
FileSize
drupal-cron-2863464-9.patch493 bytes

Re-roll for D9-beta2.

Status: Needs review » Needs work

The last submitted patch, 9: drupal-cron-2863464-9.patch, failed testing. View results

efpapado’s picture

efpapado CreditAttribution: efpapado as a volunteer commented
Status: Needs work » Needs review

Failing tests seem to pass on second iteration.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Needs work

This only changes one of the messages, the original patch changed four messages.

I would go so far to argue that "Starting execution" is not even informational, debug level at best, but downgrading it to info is a good start.

efpapado’s picture

efpapado CreditAttribution: efpapado as a volunteer commented
Status: Needs work » Needs review
FileSize
drupal-cron-2863464-13.patch1.63 KB

Agree in both, new patch attached.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

lhridley’s picture

lhridley CreditAttribution: lhridley as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

Oh, I was just asking the question in Drupal #support on the rationale behind logging the very cron messages that this patch addresses as Notices and not Info messages.

Applied and tested, Working as designed. Thanks for this!

Marking RTBC!

  • catch committed 6f4c546 on 9.2.x 
    Issue #2863464 by efpapado, cburschka, longwave, lhridley: Demote cron...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 6f4c546 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.