Cache: Convert system functional tests to phpunit

looks like we need to refactor

assertSessionCookieOnClient::assertSessionCookieOnClient()

to use

$this->assertSession()->cookieEquals() to check for the presence of the session name?

[Just feeling my way forward here.]

@Jo Fitzgerald
Also note: For backward compatibility reasons we have to leave the traits and base classes around there as well. Instead copy them into the right directory.

Simple reroll, due to recent changes in TrackerTest.php

less errors.

+++ b/core/modules/views/src/Tests/Plugin/ExposedFormTest.php
@@ -4,7 +4,7 @@
+use Drupal\Tests\system\Functional\Cache\AssertPageCacheContextsAndTagsTrait;

Does that mean we should move/copy over the trait here?

I am thinking of doing something potentially controversial, so it is worth talking about it first

From the perspective of

https://events.drupal.org/baltimore2017/sessions/backwards-compatibility...

We are marking @depreciated several implied public APIs in our base classes.

./Cache/CacheTestBase.php
./Cache/GenericCacheBackendUnitTestBase.php
./Cache/PageCacheTagsTestBase.php

I want to go the extra step and mark the replacement base classes as @internal so that we can
signal that we are dropping long term legacy support for those public APIs.

I am happy to write the change record that come with this....

but hey if anyone objects please let me know.

Totally +1 for that. Sharing that kind of code outside of core has a really limited usecase. I like this thinking.

This deprecates the WebTestBase AssertPageCacheContextsAndTagsTrait, it only updates the BrowserTestBase tests to use the new version and leaves the old deprecated version on the WebTestBase tests.

While I'm all for #12, starting to implement that here sounds a bit off. It's something we need to do for all converted test bases then. So I'd be all for opening an issue where we @internal all BrowserTestBase TestBase classes. And then from that point on, we do it for all new conversions when appropriate.

Here we go with fixes. It will un-postpone few issues in the queue.

We couldn't trigger error right now, b/c Webtestbase is using WTB AssertPageCacheContextsAndTagsTrait. So the interim solution is to remove the trigger_error for now.

//Naveen

Removed the deprecation trigger_error for now

//Naveen

Removing the trigger_error for now until we have a good way to handle them in our tests sounds like a good way to keep this moving. Adding the trigger_error later is easily done.

The rest looks nice and minimal.

Applied the patch to check all the moves and remaining files in core/modules/system/src/Tests/Cache. Everything in that folder is now @deprecated so this patch covers the correct scope.

+++ b/core/modules/system/tests/src/Functional/Cache/SessionExistsCacheContextTest.php
@@ -59,8 +59,7 @@ public function testCacheContext() {
   public function assertSessionCookieOnClient($expected_present) {
-    $non_deleted_cookies = array_filter($this->cookies, function ($item) { return $item['value'] !== 'deleted'; });
-    $this->assertEqual($expected_present, isset($non_deleted_cookies[$this->getSessionName()]), 'Session cookie exists.');
+    $this->assertEqual($expected_present, (bool) $this->getSession()->getCookie($this->getSessionName()), 'Session cookie exists.');
   }

<3

This is SO much simpler! I wrote that original code and hated it, but that's what was necessary.

Looks good other than:

+++ b/core/modules/system/src/Tests/Cache/AssertPageCacheContextsAndTagsTrait.php
@@ -9,6 +9,10 @@
+ * @deprecated Scheduled for removal in Drupal 9.0.0. Use
+ *  \Drupal\Tests\system\Functional\Cache\AssertPageCacheContextsAndTagsTrait
+ *  instead.
  */

Should have a @see to a change notice according to current guidelines :)

Added a change notice, https://www.drupal.org/node/2896632. Still needs a @see in the patch

added @see

@martin107 thanks!

Committed/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!

published the change record