Integration with Context [#2862824]

I was wondering if we could have a sub-module to provide a way to easily add and remove stuff on AMP pages.

Proposed solution

Create a context condition that can be used to add stuff (blocks, etc) on AMP pages
A global switch to disable contexts that do not meet the AMP condition. This should be optional.

Comment	File	Size	Author
#13	integration_with_context-2862824-13.patch	9.04 KB	marcelovani
#13	7.x-1.x: PHP 5.6 & MySQL 5.5, D7 2 pass, 3 fail
#9	integration_with_context-2862824-9.patch	8.13 KB	marcelovani
#9	7.x-1.x: PHP 5.6 & MySQL 5.5, D7 2 pass, 3 fail PHP 5.6 & MySQL 5.5, D7 2 pass, 3 fail
#5	integration_with_context-2862824-5.patch	8.12 KB	marcelovani
#5	7.x-1.x: PHP 5.6 & MySQL 5.5, D7 2 pass, 3 fail
#2	integration_with_context-2862824-1.patch	8.06 KB	marcelovani
#2	7.x-1.x: PHP 5.6 & MySQL 5.5, D7 2 pass, 3 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

22 March 2017 at 10:24

marcelovani created an issue. See original summary.

Comment #2

marcelovani

Portuguese, Brazil

London

CreditAttribution: marcelovani at Dennis commented 22 March 2017 at 10:58

Status:

Active

» Needs review

File	Size
integration_with_context-2862824-1.patch	8.06 KB
7.x-1.x: PHP 5.6 & MySQL 5.5, D7 2 pass, 3 fail

Comment #3

guardiola86 CreditAttribution: guardiola86 commented 24 March 2017 at 12:23

Status:

Needs review

» Reviewed & tested by the community

I've tested your submodule and works great.

Comment #4

marcelovani

Portuguese, Brazil

London

CreditAttribution: marcelovani at Dennis commented 9 April 2017 at 00:20

Assigned:

marcelovani

» Unassigned

Comment #5

marcelovani

Portuguese, Brazil

London

CreditAttribution: marcelovani at Dennis commented 11 April 2017 at 17:32

File	Size
integration_with_context-2862824-5.patch	8.12 KB
7.x-1.x: PHP 5.6 & MySQL 5.5, D7 2 pass, 3 fail

Looks like I missed a 'little' detail, re-uploading patch

Comment #6

marcelovani

Portuguese, Brazil

London

CreditAttribution: marcelovani at Dennis commented 12 May 2017 at 11:54

Status:

Reviewed & tested by the community

» Needs review

Changing status to make tests run

Comment #7

12 May 2017 at 23:58

The last submitted patch, 2: integration_with_context-2862824-1.patch, failed testing.

Comment #8

12 May 2017 at 23:58

Status:

Needs review

» Needs work

The last submitted patch, 5: integration_with_context-2862824-5.patch, failed testing.

Comment #9

marcelovani

Portuguese, Brazil

London

CreditAttribution: marcelovani at Dennis commented 22 May 2017 at 10:09

Status:

Needs work

» Needs review

File	Size
integration_with_context-2862824-9.patch	8.13 KB
7.x-1.x: PHP 5.6 & MySQL 5.5, D7 2 pass, 3 fail PHP 5.6 & MySQL 5.5, D7 2 pass, 3 fail

re-rolled patch

Comment #10

22 May 2017 at 22:16

Status:

Needs review

» Needs work

The last submitted patch, 9: integration_with_context-2862824-9.patch, failed testing.

Comment #11

marcelovani

Portuguese, Brazil

London

CreditAttribution: marcelovani at Dennis commented 24 May 2017 at 11:26

Status:

Needs work

» Needs review

Comment #12

24 May 2017 at 11:34

Status:

Needs review

» Needs work

The last submitted patch, 9: integration_with_context-2862824-9.patch, failed testing.

Comment #13

marcelovani

Portuguese, Brazil

London

CreditAttribution: marcelovani at Dennis commented 24 May 2017 at 11:39

Status:

Needs work

» Needs review

File	Size
integration_with_context-2862824-13.patch	9.04 KB
7.x-1.x: PHP 5.6 & MySQL 5.5, D7 2 pass, 3 fail

Created helper module to download dependencies on drupal CI

Comment #14

24 May 2017 at 11:43

Status:

Needs review

» Needs work

The last submitted patch, 13: integration_with_context-2862824-13.patch, failed testing.

Comment #15

4 October 2017 at 09:55

marcelovani committed 10a952f on 7.x-1.x

Issue #2862824 by marcelovani: Integration with Context

Comment #16

marcelovani

Portuguese, Brazil

London

CreditAttribution: marcelovani at Dennis commented 4 October 2017 at 09:57

Status:

Needs work

» Fixed

We have been using this patch in production for a couple of months and it works fine. The new sub-modules is completely detached from the main module.