Admin toolbar tools is missing for admin user.

CommentFileSizeAuthor
#2 social_admin_menu-2862779-1-fix-admin-condition.patch943 bytesRaSpirit
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RaSpirit created an issue. See original summary.

RaSpirit’s picture

RaSpirit CreditAttribution: RaSpirit commented
FileSize
social_admin_menu-2862779-1-fix-admin-condition.patch943 bytes

The issue is in

\Drupal\social_admin_menu\Menu\SocialAdminMenuAdministratorMenuLinkTreeManipulators::checkAccess()

method

($this->account->id() !== 1)

Does not work fine, since id() method returns string, so !== should be replaced by !=

jochemvn’s picture

jochemvn CreditAttribution: jochemvn for Open Social commented
Priority: Normal » Critical
frankgraave’s picture

frankgraave CreditAttribution: frankgraave for Open Social commented

Hi RaSpirit,

I've taken your fix into this pull request https://github.com/goalgorilla/open_social/pull/356 which is now up for review.

frankgraave’s picture

frankgraave CreditAttribution: frankgraave for Open Social commented
Status: Needs review » Reviewed & tested by the community

  • 4c6c5c8 committed on 8.x-1.x 
    Merge pull request #356 from goalgorilla/feature/2862779

Issue #2862779...
  • frankgraave committed 94f3c47 on 8.x-1.x
    Issue #2862779 by frankgraave: changed argument according to core update...
jochemvn’s picture

jochemvn CreditAttribution: jochemvn for Open Social commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.