Exposed taxonomy dropdown filter inconsistently sorted by translation [#2862533]

Steps to reproduce:

- Enable views, taxonomy, content translation
- Enable the languages German and French
- Create a vocabulary with these terms and the corresponding translations:

- Albania / Albanien / Albanie
- Egypt / Ägypten / Égypt
- Finland / Finnland / Finlande
- Germany / Deutschland / Allemagne
- Saudi Arabia / Saudi-Arabien / Arabie saoude

- Create a view with an exposed taxonomy term filter.
- Open the view in English, German and French.

Expected ordering of the taxonomy terms:

English: Albania, Egypt, Finland, Germany, Saudi Arabia
German: Ägypten, Albanien, Deutschland, Finnland, Saudi-Arabien
French: Albanie, Allemagne, Arabie saoude, Égypt, Finlande

Actual ordering in all languages:

Egypt, Albania, Germany, Saudi Arabia, Finland

As can be seen, each term is in the first position allowed by any of its translations: Egypt by its German name, Germany and Saudi Arabia by their French names.

It seems that in the query, the terms are selected without language filtering, ordered alphabetically, and then the TIDs are de-duplicated before being passed to Term::loadMultiple.

The fix would be inserting a langcode filter into the entity query.

Comment	File	Size	Author
#21	2862533-21-taxonomy-filter-sort.patch	1.44 KB	florianmuellerCH
#21	8.9.x: PHP 7.3 & MySQL 5.7 Patch Failed to Apply 9.1.x: PHP 7.4 & MySQL 5.6 Build Successful
#20	interdiff_18_20.txt	792 bytes	anmolgoyal74
#20	2862533-20-taxonomy-filter-sort.patch	1.99 KB	anmolgoyal74
#20	8.9.x: PHP 7.4 & MySQL 5.7 28,605 pass
#18	2862533-18-taxonomy-filter-sort.patch	1.98 KB	tomasbarej
#18	8.9.x: PHP 7.4 & MySQL 5.7 28,600 pass, 2 fail
#14	2862533-14-taxonomy-filter-sort.patch	1.73 KB	florianmuellerCH
#14	8.6.x: PHP 7.1 & MySQL 5.7 Patch Failed to Apply 8.7.x: PHP 7.1 & MySQL 5.7 26,347 pass, 1 fail
#10	2862533-10.patch	1.72 KB	gaurav.kapoor
#10	8.3.x: PHP 5.6 & MySQL 5.5 21,474 pass
#6	drupal-taxonomy-filter-sort-2862533.patch	1.85 KB	cburschka
#6	8.3.x: PHP 5.6 & MySQL 5.5 Patch Failed to Apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

21 March 2017 at 15:14

cburschka created an issue. See original summary.

Comment #2

cburschka

they

CreditAttribution: cburschka at PwC's Experience Center commented 21 March 2017 at 15:16

Issue summary:

View changes

Comment #3

dagmar

Spanish

Argentina

CreditAttribution: dagmar as a volunteer and at Globant commented 21 March 2017 at 17:40

There is a similar issue #1821274: Add back ability to sort on vocabulary weight and name that was closed without explanation. Actually there is some relevant code at TaxonomyIndexTid

      else {
        $options = [];
        $query = \Drupal::entityQuery('taxonomy_term')
          // @todo Sorting on vocabulary properties -
          //   https://www.drupal.org/node/1821274.
          ->sort('weight')
          ->sort('name')
          ->addTag('taxonomy_term_access');
        if ($this->options['limit']) {
          $query->condition('vid', $vocabulary->id());
        }
        $terms = Term::loadMultiple($query->execute());
        foreach ($terms as $term) {
          $options[$term->id()] = \Drupal::entityManager()->getTranslationFromContext($term)->label();
        }
      }

Comment #4

cburschka

they

CreditAttribution: cburschka at PwC's Experience Center commented 21 March 2017 at 18:11

Indeed, the current approach is broken because it doesn't even present the terms correctly in a single default language. It's not like "we're in language X, but the terms are sorted by their language Y translations". Rather "all translations from languages X,Y,Z are sorted in one list, then all but the first occurrence of each term are discarded", which yields gibberish.

As the translation of each term is not acquired until later, it is impossible to apply any ordering in the entity query; the sorting has to be done in PHP on the results.

        foreach ($terms as $term) {
          $options[$term->id()] = \Drupal::entityManager()->getTranslationFromContext($term)->label();
        }
        // only now do we actually know what the term names are, and how to sort them.

Comment #5

cburschka

they

CreditAttribution: cburschka at PwC's Experience Center commented 21 March 2017 at 18:27

I would suggest the following, but it can probably be improved on:

        $weighted = [];
        $query = \Drupal::entityQuery('taxonomy_term')
          ->addTag('taxonomy_term_access');
        if ($this->options['limit']) {
          $query->condition('vid', $vocabulary->id());
        }
        /** @var \Drupal\taxonomy\TermInterface[] $terms */
        $terms = Term::loadMultiple($query->execute());
        foreach ($terms as $term) {
          $weighted[$term->getWeight()][$term->id()] = \Drupal::entityManager()
                                                              ->getTranslationFromContext($term)
                                                              ->label();
        }
        ksort($weighted);
        $options = [];
        foreach ($weighted as $weight => $weight_options) {
          asort($weight_options);
          $options += $weight_options;
        }

Comment #6

cburschka

they

CreditAttribution: cburschka at PwC's Experience Center commented 22 March 2017 at 10:07

Status:

Active

» Needs review

File	Size
drupal-taxonomy-filter-sort-2862533.patch	1.85 KB
8.3.x: PHP 5.6 & MySQL 5.5 Patch Failed to Apply

Patch is for 8.2.7, but as far as I can tell this should still apply to 8.3.x.

Comment #7

22 March 2017 at 10:14

Status:

Needs review

» Needs work

The last submitted patch, 6: drupal-taxonomy-filter-sort-2862533.patch, failed testing.

Comment #8

dagmar

Spanish

Argentina

CreditAttribution: dagmar as a volunteer and at Globant commented 22 March 2017 at 10:15

@cburschka It will not apply to 8.3.x because array() syntax was replaced by [] syntax.

Comment #9

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commented 22 March 2017 at 10:40

Assigned:

Unassigned

» gaurav.kapoor

Comment #10

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commented 22 March 2017 at 10:53

Assigned:	gaurav.kapoor	» Unassigned
Status:	Needs work	» Needs review

File	Size
2862533-10.patch	1.72 KB
8.3.x: PHP 5.6 & MySQL 5.5 21,474 pass

Re-roll

Comment #11

22 March 2017 at 10:53

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #12

22 March 2017 at 10:53

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #13

22 March 2017 at 10:53

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #14

florianmuellerCH

German

Aarau, Switzerland

CreditAttribution: florianmuellerCH commented 14 June 2019 at 14:13

File	Size
2862533-14-taxonomy-filter-sort.patch	1.73 KB
8.6.x: PHP 7.1 & MySQL 5.7 Patch Failed to Apply 8.7.x: PHP 7.1 & MySQL 5.7 26,347 pass, 1 fail

File

Size

2862533-14-taxonomy-filter-sort.patch

1.73 KB

8.6.x:
PHP 7.1 & MySQL 5.7 Patch Failed to Apply

8.7.x:
PHP 7.1 & MySQL 5.7 26,347 pass, 1 fail

Re-rolled it against 8.7

Comment #15

florianmuellerCH

German

Aarau, Switzerland

CreditAttribution: florianmuellerCH commented 14 June 2019 at 14:14

Version:

8.6.x-dev

» 8.7.x-dev

Comment #16

14 June 2019 at 14:14

Version:

8.7.x-dev

» 8.8.x-dev

Drupal 8.7.9 was released on November 6 and is the final full bugfix release for the Drupal 8.7.x series. Drupal 8.7.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.8.0 on December 4, 2019. (Drupal 8.8.0-beta1 is available for testing.)

Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #17

14 June 2019 at 14:14

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.