Problem/Motivation

Spun off from #2831274-202: Bring Media entity module to core as Media module, point 1. Reproduced here:

+++ b/core/modules/media/config/install/core.entity_view_mode.media.full.yml
@@ -0,0 +1,9 @@
+label: 'Full content'

Naming is strange but looks separate task

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 new_viewmode_media2.png52.02 KBmarcoscano
#3 new_viewmode_media1.png48.51 KBmarcoscano
#3 node_viewmodes.png38.34 KBmarcoscano
#2 default-view-mode.png29.83 KByoroy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
Issue summary: View changes
FileSize
default-view-mode.png29.83 KB

For regular content types we use "default" as the label for the full display:

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano at Lullabot commented
FileSize
node_viewmodes.png38.34 KB
new_viewmode_media1.png48.51 KB
new_viewmode_media2.png52.02 KB

Re: #2, I'm not sure about that. Node's full viewmode has also the same label:

langcode: en
status: false
dependencies:
  module:
    - node
id: node.full
label: 'Full content'
targetEntityType: node
cache: true

And in a clean install you have the list of viewmodes for nodes as:

node viewmodes

As soon as you create a new viewmode for media, and enable custom display settings for it:

new media viewmode1

you'll get the same UI we have for nodes:

new media viewmode 2

So there's no real difference between media and nodes on this aspect. Based on this, should we close this as "works as designed"?

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Issue summary: View changes
Issue tags: +Media Initiative

Cleaning up the IS a bit.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Issue summary: View changes

Sorry, one more thing.

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented

Yeah my #2 is incorrect. So does this really need changing? "Full media content" ?

seanB’s picture

seanB
Primary language Dutch
Location Netherlands
CreditAttribution: seanB commented

I guess this should be consistent with node. So if we want to change it, let's change it for node as well. Not sure about the label. Maybe 'Page' is an alternative, since it is primarily being used for the detail page?

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Component: media system » user interface text
Issue tags: +Usability

Well, right now, as @seanB points out, Media's full view mode is called "Full content", as is Node's. So if it needs changing, I agree that they should both be changed in this issue, across core. To me, this is not a Media-specific question, so I'm widening the issue's scope and categorization. Maybe we should also remove this from Media's roadmap too (#2825215: Media initiative: Roadmap).

So...the bike shed is open for business! What shall we call the full view mode(s)?

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented

Bikeshedding is no fun, lets protect ourselves from wasting time on non productive busywork instead.

I see no reason to change it. Media is content, lets not worry too much about it.

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
Status: Active » Closed (won't fix)

And with that… marking as won't fix.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Agreed with @yoroy.