"Passwords Match:" text shows below password_confirm element on initial page load [#2862256]

Problem/Motivation

You will notice that when viewing the register form you will see "Passwords Match:" showing below the second confirm password box. It should be hidden initially when the page loads and only show as you start to type the second password. When you start typing your password the text will disappear.

This was introduced with: #1751434: Selectors clean-up: user module
This changed the class on that wrapper field from .password-confirm-match to .password-confirm, the CSS that controls this element was not updated and still has the old id (https://github.com/drupal/drupal/blob/8.4.x/core/modules/user/css/user.m...).

This could be fixed by the (long) upcoming #2293803: Replace confirm password element with a new password element with show/hide functionality but is a bug that needs fixing till then.

Steps to reproduce

Drupal 10.1.x, this occurs with Stark and Olivero but not Claro.

Proposed resolution

TBA

Remaining tasks

Decide if the password strength text should be in included in this change.
Update patch
review
commit

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#32	interdiff_26-32.txt	4.63 KB	ranjith_kumar_k_u
#32	2862256-32.patch	2.85 KB	ranjith_kumar_k_u
#32	10.1.x: PHP 8.1 & MySQL 5.7 29,366 pass
#26	2862256-26.patch	3.04 KB	Prem Suthar
#26	10.1.x: PHP 8.1 & MySQL 5.7 28,984 pass, 2 fail
#19	interdiff_15_19.txt	3.7 KB	anmolgoyal74
#19	2862256-19.patch	4.42 KB	anmolgoyal74
#19	9.2.x: PHP 7.3 & MySQL 5.7 28,051 pass, 4 fail
#18	after-patch.png	7.38 KB	sulfikar_s
#17	2862256-17.patch	358 bytes	nikitagupta
#17	9.2.x: PHP 7.3 & MySQL 5.7 28,054 pass
#15	2862256-15.patch	362 bytes	anmolgoyal74
#15	9.2.x: PHP 7.3 & MySQL 5.7 28,022 pass, 3 fail
#14	passwords_match_class_fix-2862256-14.patch	362 bytes	toddses
#14	8.9.x: PHP 7.3 & MySQL 5.7 28,616 pass PHP 7.3 & MySQL 5.7 28,616 pass
#13	passwords_match_class_fix-2862256-13.patch	376 bytes	toddses
#13	8.9.x: PHP 7.3 & MariaDB 10.3.22 Patch Failed to Apply PHP 7.3 & MySQL 5.7 Patch Failed to Apply PHP 7.3 & PostgreSQL 10.12 Patch Failed to Apply PHP 7.3 & SQLite 3.28 Patch Failed to Apply PHP 7.3 & MySQL 5.7 Patch Failed to Apply
#2	passwords_match_class_fix-2862256-2.patch	1.05 KB	rbrandon
#2	8.4.x: PHP 5.6 & MySQL 5.5 21,486 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 March 2017 at 19:10

rbrandon created an issue. See original summary.

Comment #2

rbrandon CreditAttribution: rbrandon at Richard Brandon Consulting LLC for The Open Prosthetics Project commented 20 March 2017 at 19:43

Status:

Needs work

» Needs review

File	Size
passwords_match_class_fix-2862256-2.patch	1.05 KB
8.4.x: PHP 5.6 & MySQL 5.5 21,486 pass

This patch changes the class back to password-confirm-match this both distinguishes it from the input with the same class, and fixes the css hide issue.

Comment #3

rbrandon CreditAttribution: rbrandon at Richard Brandon Consulting LLC for The Open Prosthetics Project commented 23 March 2017 at 18:37

For a patch for this issue along with #2862278 see https://www.drupal.org/node/2862278#comment-12002956.

Comment #4

LoMo CreditAttribution: LoMo as a volunteer commented 29 April 2017 at 22:46

Status:

Needs review

» Needs work

I'd hoped to be able to move this issue along, since it's been sitting with no action for so long, but I still see the "Passwords match:" text when the page loads, even after applying the patch. (And yes, even after clearing both Drupal and browser caches.) Maybe something has changed since your patch was created. Or maybe I'm missing something, but at least I've attempted to test your patch and don't see any visible difference there. I've tried with both the /admin/people/create user-form and with a plain authenticated user logged in (editing own password on "user/123/edit"). In all cases the behavior is as you describe and applying the patch does not seem to change it.

Comment #5

jludwig CreditAttribution: jludwig as a volunteer commented 1 May 2017 at 06:19

Note: the issue summary mentions that "This could be fixed by the (long) upcoming https://www.drupal.org/node/2293803 but is a bug that needs fixing till then," but that issue adds the new show password functionality as a configuration that is off by default, so this will be needed even if that issue does get in.

Comment #6

1 May 2017 at 06:19

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #7

1 May 2017 at 06:19

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #8

1 May 2017 at 06:19

Version:

8.6.x-dev

» 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #9

1 May 2017 at 06:19

Version:

8.7.x-dev

» 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #10

1 May 2017 at 06:19

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #11

1 May 2017 at 06:19

Version:

8.9.x-dev

» 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #12

1 May 2017 at 06:19

Version:

9.1.x-dev

» 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Comment #13

toddses CreditAttribution: toddses as a volunteer commented 31 December 2020 at 16:07

File	Size
passwords_match_class_fix-2862256-13.patch	376 bytes
8.9.x: PHP 7.3 & MariaDB 10.3.22 Patch Failed to Apply PHP 7.3 & MySQL 5.7 Patch Failed to Apply PHP 7.3 & PostgreSQL 10.12 Patch Failed to Apply PHP 7.3 & SQLite 3.28 Patch Failed to Apply PHP 7.3 & MySQL 5.7 Patch Failed to Apply

Quick patch that includes a CSS class change that resolved the issue for me. Seems at this point, the CSS just needs to be updated to the new class.

Comment #14

toddses CreditAttribution: toddses as a volunteer commented 31 December 2020 at 16:19

File	Size
passwords_match_class_fix-2862256-14.patch	362 bytes
8.9.x: PHP 7.3 & MySQL 5.7 28,616 pass PHP 7.3 & MySQL 5.7 28,616 pass

patch in #13 doesn't apply cleanly, rerolling.

Comment #15

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented 3 January 2021 at 18:19

Status:

Needs work

» Needs review

File	Size
2862256-15.patch	362 bytes
9.2.x: PHP 7.3 & MySQL 5.7 28,022 pass, 3 fail

Added patch for 9.2.x

Comment #16

3 January 2021 at 19:19

Status:

Needs review

» Needs work

The last submitted patch, 15: 2862256-15.patch, failed testing. View results

Comment #17

nikitagupta CreditAttribution: nikitagupta at Srijan | A Material+ Company for Drupal India Association commented 12 January 2021 at 06:40

Status:

Needs work

» Needs review

File	Size
2862256-17.patch	358 bytes
9.2.x: PHP 7.3 & MySQL 5.7 28,054 pass

Comment #18

sulfikar_s CreditAttribution: sulfikar_s at Zyxware Technologies commented 14 January 2021 at 18:06

Status:

Needs review

» Needs work

File	Size
after-patch.png	7.38 KB

Hi, the patch in #17 applied cleanly. But doesn't make any change. The "Passwords Match:" text still shows on page loading.

I'm attaching the screenshots below,

I think this needs work!

Comment #19

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented 14 January 2021 at 18:55

Status:

Needs work

» Needs review

File	Size
2862256-19.patch	4.42 KB
9.2.x: PHP 7.3 & MySQL 5.7 28,051 pass, 4 fail
interdiff_15_19.txt	3.7 KB

Updated tests.

Comment #20

14 January 2021 at 19:54

Status:

Needs review

» Needs work

The last submitted patch, 19: 2862256-19.patch, failed testing. View results

Comment #21

14 January 2021 at 19:54

Version:

9.2.x-dev

» 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #22

14 January 2021 at 19:54

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #23

14 January 2021 at 19:54

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #24

14 January 2021 at 19:54

Version:

9.5.x-dev

» 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #25

quietone CreditAttribution: quietone at PreviousNext commented 15 February 2023 at 00:30

Issue summary:	View changes
Issue tags:		+Bug Smash Initiative, +Needs issue rescope

This was a bugsmash daily target, discussed by myself and lendude.

The issue is still valid. On Drupal 10.1.x, it occurs with Stark and Olivero but not Claro. It is not clear why this is only changing the 'match' text and not the 'strength' text as well. Tagging for an issue rescope to consider that question.

Comment #26

Prem Suthar CreditAttribution: Prem Suthar at Srijan | A Material+ Company for Drupal India Association commented 1 March 2023 at 10:50

File	Size
2862256-26.patch	3.04 KB
10.1.x: PHP 8.1 & MySQL 5.7 28,984 pass, 2 fail

Re-roll the Patch For 10.1 Branch.

Comment #27

ameymudras CreditAttribution: ameymudras at Salsa Digital commented 6 March 2023 at 16:07

Status:

Needs work

» Needs review

Moving the issue to NR as the patch is submitted in #26

Comment #28

6 March 2023 at 17:09

Status:

Needs review

» Needs work

The last submitted patch, 26: 2862256-26.patch, failed testing. View results

Comment #29

Indrapatil CreditAttribution: Indrapatil at Valuebound for Valuebound commented 7 March 2023 at 05:08

Assigned:

Unassigned

» Indrapatil

Comment #30

Indrapatil CreditAttribution: Indrapatil at Valuebound for Valuebound commented 8 March 2023 at 17:15

Assigned:

Indrapatil

» Unassigned

Comment #31

Meeni_Dhobale CreditAttribution: Meeni_Dhobale as a volunteer and at QED42 for Drupal India Association commented 13 March 2023 at 13:05

I tried the last updated #26, and it seem that issue is not soved yet. Need to work on this.

Comment #32

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented 1 May 2023 at 09:26

File	Size
2862256-32.patch	2.85 KB
10.1.x: PHP 8.1 & MySQL 5.7 29,366 pass
interdiff_26-32.txt	4.63 KB

Updated the tests as per the provided solution, and not changing the status to Needs Review because of the Needs issue rescope

Comment #33

1 May 2023 at 12:59

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.