Problem/Motivation
You will notice that when viewing the register form you will see "Passwords Match:" showing below the second confirm password box. It should be hidden initially when the page loads and only show as you start to type the second password. When you start typing your password the text will disappear.
This was introduced with: #1751434: Selectors clean-up: user module
This changed the class on that wrapper field from .password-confirm-match to .password-confirm, the CSS that controls this element was not updated and still has the old id (https://github.com/drupal/drupal/blob/8.4.x/core/modules/user/css/user.m...).
This could be fixed by the (long) upcoming #2293803: Replace confirm password element with a new password element with show/hide functionality but is a bug that needs fixing till then.
Steps to reproduce
Drupal 10.1.x, this occurs with Stark and Olivero but not Claro.
Proposed resolution
TBA
Remaining tasks
Decide if the password strength text should be in included in this change.
Update patch
review
commit
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#32 | interdiff_26-32.txt | 4.63 KB | ranjith_kumar_k_u |
#32 | 2862256-32.patch | 2.85 KB | ranjith_kumar_k_u |
| |||
#26 | 2862256-26.patch | 3.04 KB | Prem Suthar |
#19 | interdiff_15_19.txt | 3.7 KB | anmolgoyal74 |
#19 | 2862256-19.patch | 4.42 KB | anmolgoyal74 |
Comments
Comment #2
rbrandon CreditAttribution: rbrandon at Richard Brandon Consulting LLC for The Open Prosthetics Project commentedThis patch changes the class back to password-confirm-match this both distinguishes it from the input with the same class, and fixes the css hide issue.
Comment #3
rbrandon CreditAttribution: rbrandon at Richard Brandon Consulting LLC for The Open Prosthetics Project commentedFor a patch for this issue along with #2862278 see https://www.drupal.org/node/2862278#comment-12002956.
Comment #4
LoMo CreditAttribution: LoMo as a volunteer commentedI'd hoped to be able to move this issue along, since it's been sitting with no action for so long, but I still see the "Passwords match:" text when the page loads, even after applying the patch. (And yes, even after clearing both Drupal and browser caches.) Maybe something has changed since your patch was created. Or maybe I'm missing something, but at least I've attempted to test your patch and don't see any visible difference there. I've tried with both the /admin/people/create user-form and with a plain authenticated user logged in (editing own password on "user/123/edit"). In all cases the behavior is as you describe and applying the patch does not seem to change it.
Comment #5
jludwig CreditAttribution: jludwig as a volunteer commentedNote: the issue summary mentions that "This could be fixed by the (long) upcoming https://www.drupal.org/node/2293803 but is a bug that needs fixing till then," but that issue adds the new show password functionality as a configuration that is off by default, so this will be needed even if that issue does get in.
Comment #13
toddses CreditAttribution: toddses as a volunteer commentedQuick patch that includes a CSS class change that resolved the issue for me. Seems at this point, the CSS just needs to be updated to the new class.
Comment #14
toddses CreditAttribution: toddses as a volunteer commentedpatch in #13 doesn't apply cleanly, rerolling.
Comment #15
anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commentedAdded patch for 9.2.x
Comment #17
nikitagupta CreditAttribution: nikitagupta at Srijan | A Material+ Company for Drupal India Association commentedComment #18
sulfikar_s CreditAttribution: sulfikar_s at Zyxware Technologies commentedHi, the patch in #17 applied cleanly. But doesn't make any change. The "Passwords Match:" text still shows on page loading.
I'm attaching the screenshots below,
I think this needs work!
Comment #19
anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commentedUpdated tests.
Comment #25
quietone CreditAttribution: quietone at PreviousNext commentedThis was a bugsmash daily target, discussed by myself and lendude.
The issue is still valid. On Drupal 10.1.x, it occurs with Stark and Olivero but not Claro. It is not clear why this is only changing the 'match' text and not the 'strength' text as well. Tagging for an issue rescope to consider that question.
Comment #26
Prem Suthar CreditAttribution: Prem Suthar at Srijan | A Material+ Company for Drupal India Association commentedRe-roll the Patch For 10.1 Branch.
Comment #27
ameymudras CreditAttribution: ameymudras at Salsa Digital commentedMoving the issue to NR as the patch is submitted in #26
Comment #29
Indrapatil CreditAttribution: Indrapatil at Valuebound for Valuebound commentedComment #30
Indrapatil CreditAttribution: Indrapatil at Valuebound for Valuebound commentedComment #31
Meeni_Dhobale CreditAttribution: Meeni_Dhobale as a volunteer and at QED42 for Drupal India Association commentedI tried the last updated #26, and it seem that issue is not soved yet. Need to work on this.
Comment #32
ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedUpdated the tests as per the provided solution, and not changing the status to Needs Review because of the Needs issue rescope