STOMT provides an own feedback standard and a social network to manage it.

It's like a consumer friendly Github-Issues-system (you wouldn't send your mum to Github to leave feedback, wouldn't you?).

This module is a wrapper for our javascript-widget: https://github.com/stomt/stomt-javascript-sdk

This is an example:
http://forum.eotugame.com has our feedback-widget installed. The feedback is collected on their public STOMT-profile: https://www.stomt.com/empires-of-the-undergrowth

Project page: https://www.drupal.org/sandbox/stomt/stomt
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/stomt/stomt.git stomt && cd stomt

PS: It would be great if you could tell me if there is anything to be done to make it also run for Drupal 8.

Comments

philippzentner created an issue. See original summary.

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxstomtstomtgit

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Yogesh Kushwaha’s picture

Yogesh Kushwaha CreditAttribution: Yogesh Kushwaha commented

Please remove these error which are related to coding standard.

https://pareview.sh/node/1423

Ankush_03’s picture

Ankush_03
Location Gurgaon, India 🇮🇳
CreditAttribution: Ankush_03 commented

HI ,
Below is my manual review ,

1. use proper commenting online 56 for hook_menu
2. add install file for variable uninstall.

philippzentner’s picture

philippzentner CreditAttribution: philippzentner commented

Okay guys, thanks for the review.

I fixed all errors except of one: "Invalid function name, expected s_to_mt_help but found STOMT_help". As soon as i change it to "s_to_mt_help" it also fails as the module name is "STOMT". I think there is some logic that recognize the "to" as a word and wants me to make the function more readable. So that should be an error to be ignored.

Also, is it really necessary to add an .install file? I just make us of variable_set/get and that works perfectly. I wouldn't even know what to write in as i do not create an own database table nor do i make any database changes at all.

Thanks in advance.

philippzentner’s picture

philippzentner CreditAttribution: philippzentner commented
Status: Needs work » Needs review
Ankush_03’s picture

Ankush_03
Location Gurgaon, India 🇮🇳
CreditAttribution: Ankush_03 commented

HI philippzentner ,

/**
* Implements hook_uninstall().
*/
function modulename_uninstall() {
variable_del('your_variable_name');
}

it is necessary to delete variable because if your module has been disabled then variable entry not deleted from variable table.

philippzentner’s picture

philippzentner CreditAttribution: philippzentner commented

Totally makes sense! Thought that would be done automatically.
I added a hook_uninstall into a new created .install file.

Thanks for the fast feedback! Anything else?

Also, is it already possible to make use of [] instead of array()? I'm totally new to Drupal and was not sure which PHP versions are normal on D7 installations.

Another question: Can i just create a new branch for 8.X-1.X to also make it available for D8? If so, do you encounter any necessary changes on a quick glimpse over the code? Thanks.

Ankush_03’s picture

Ankush_03
Location Gurgaon, India 🇮🇳
CreditAttribution: Ankush_03 commented

Hi philippzentner,
Use of array is a good practice and support all versions in php.
For d8 branch please wait for ur module publish, once it publish then port it to d8 version.

philippzentner’s picture

philippzentner CreditAttribution: philippzentner commented

Okay, can you do the final review for this? What has to happen? Everything should be fine now.

philippzentner’s picture

philippzentner CreditAttribution: philippzentner as a volunteer commented

*push*

sleitner’s picture

sleitner CreditAttribution: sleitner commented
Title: [D7] STOMT integration » [D8] STOMT integration
Status: Needs review » Needs work

Automated Review

Pareview details: https://pareview.sh/pareview/https-git.drupal.org-project-stomt.git/revi...

Review of the 8.x-1.x branch (commit fb3f8e9):

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template. See pareview details
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. (*) see pareview details

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

sleitner’s picture

sleitner CreditAttribution: sleitner commented
Issue summary: View changes
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Title: [D8] STOMT integration » [D7] STOMT integration
Status: Needs work » Needs review

@philippzentner applied using the Drupal 7 version of the project. That is the branch under review, which is still valid since Drupal 7 is a supported version.

sleitner’s picture

sleitner CreditAttribution: sleitner commented
Status: Needs review » Needs work

Automated Review

Pareview details: https://pareview.sh/pareview/https-git.drupal.org-project-stomt.git-7.x-1.x

Review of the 7.x-1.x branch (commit c65fbcd):

  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template. See pareview details
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. (*) see pareview details
  2. (*) change package name to a more informative one in STOMT.info
  3. (*) rename .install to STOMT.install

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Needs work » Closed (won't fix)

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.