As noted in #2135291 and #2776975, the coding standard regarding arrays is changing. As Drupal 8.3 is adopting the short array syntax, the Drupal 8 code for this module should follow that.

So going forward the syntax should change from

["apples", "oranges", "bananas"]

instead of

array("apples", "oranges", "bananas")
CommentFileSizeAuthor
#3 follow_the_php_5_4_array_syntax-2861950.patch40.67 KBsnufkin
#2 follow_the_php_5_4_array_syntax-2861950-2.patch42.17 KBsnufkin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

snufkin created an issue. See original summary.

snufkin’s picture

snufkin CreditAttribution: snufkin as a volunteer commented
Status: Active » Needs review
FileSize
follow_the_php_5_4_array_syntax-2861950-2.patch42.17 KB

Changes are made using the converter from https://github.com/thomasbachem/php-short-array-syntax-converter.

snufkin’s picture

snufkin CreditAttribution: snufkin as a volunteer and at Cheppers commented
FileSize
follow_the_php_5_4_array_syntax-2861950.patch40.67 KB

Updating patch to latest dev.

  • snufkin committed 0e29940 on 8.x-3.x 
    Issue #2861950 by snufkin: Follow the PHP 5.4 short array syntax
snufkin’s picture

snufkin CreditAttribution: snufkin as a volunteer and at Cheppers commented
Status: Needs review » Fixed

I'll merge as this patch does not affect functionality, hopefully with the new RC we can get more eyes on it :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.