Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The help text of the Field Layout module does not quite follow the Help text standards as described in https://www.drupal.org/help-text-standards. It misses a section to describe the Uses.
Proposed resolution
Editing the text according to the standard.
Remaining tasks
- Edit the Uses descriptions
User interface changes
This is a UI text change.
Comment | File | Size | Author |
---|---|---|---|
#16 | interdiff-2861845-9-16.txt | 1.88 KB | shashikant_chauhan |
#16 | 2861845-16-field_layout_module.patch | 1.27 KB | shashikant_chauhan |
#12 | interdiff_2861845_6-9.txt | 1.8 KB | prash_98 |
#9 | 2861845-field-layout_module.patch | 1.54 KB | prash_98 |
#7 | Before-1.png | 18.53 KB | Aanal.addweb |
Comments
Comment #2
ifrikComment #3
DuaelFrFixing event tag :p
Comment #4
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedMade some changes according to Help text standards.
Comment #6
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedSorry about the last patch. Missed semi colon.
Comment #7
Aanal.addweb CreditAttribution: Aanal.addweb at AddWeb Solution Pvt. Ltd. commented@dhruveshdtripathi, Thanks for the updated patch, it works well. I checked it via simplytest.me & also attached the images of results.
Comment #8
ifrikSorry, but the proposed text does not follow the help text standards, and it does not describe how this module can be used.
Comment #9
prash_98 CreditAttribution: prash_98 at Google Summer of Code commentedHave made the changes as suggested. Please review .
Comment #10
ifrikComment #11
prash_98 CreditAttribution: prash_98 at Google Summer of Code commentedIs there only an interdiff needed or any other issues?
Comment #12
prash_98 CreditAttribution: prash_98 at Google Summer of Code commentedHave attached the interdiff file for the above patch.
Comment #14
prash_98 CreditAttribution: prash_98 at Google Summer of Code commentedAny updates with this issue?
Comment #15
tim.plunkettThis is an incorrect change, this core module has nothing to do with https://www.drupal.org/project/fieldlayout
Comment #16
shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer and at Iksula commentedAdding updated patch based on previous comments and few minor corrections.
Comment #17
tim.plunkettNeither of these statements are true either :(
I'm very confused as to where this information is coming from?
Comment #18
ifrikI'm getting a bit lost on how to respond to this (and similar issues for hook_help texts).
We now got several patches, that describe things that the module doesn't do, and that don't follow the structure for a help text (as documented on https://www.drupal.org/help-text-standards)
It also looks like patches are just adding the same wording that other people have already added, or making new patches that are not based on the last patch but some previous one. Comments with the patches might say that the previous comments are taken into account, but looking at the interdiff's that doesn't seem to be the case.
My very practical proposal is therefore is to take this issue up during the mentored sprint at DrupalCon: starting fresh and outline what the module does in this issue first. And only when that is done, we should make a new patch.
Comment #19
michaellenahan CreditAttribution: michaellenahan at erdfisch commentedComment #20
rakesh_verma CreditAttribution: rakesh_verma as a volunteer and for Google Summer of Code commentedI'm looking at this one at DrupalCon Vienna under a mentored sprint.
Comment #21
rakesh_verma CreditAttribution: rakesh_verma as a volunteer and for Google Summer of Code commentedI had a word with @tim.plunkett at DC Vienna and we've decided to postpone working on it as of now as it's still in experimental stage and we're not really sure about the best practical Uses of Field Layout module yet.
Henceforth, we can't put the accurate "Uses" text in help section as of now.
Comment #22
rakesh_verma CreditAttribution: rakesh_verma as a volunteer and for Google Summer of Code commentedWhile we're on the topic, I'd also like to mention that the module "fieldlayout" is not same as the core "field_layout" module and probably this is the major reason of all the confusion and wrong patches.
"fieldlayout" is not the core module and both the modules work differently. Please take care of the same in future patches. :)
Comment #23
tim.plunkettTagging for our future work, and assigning to myself.
Sorry for the confusion everyone! And thanks @rakesh_verma and @ifrik.
Comment #34
quietone CreditAttribution: quietone at PreviousNext commentedThis was an issue during an documentation triage session. Field Layout is to be removed from core so I am moving this to that component. When the module is moved this can then go with it to contrib.
#3007167: [META] Enable layout builder for form displays, and deprecate field_layout
Comment #35
tim.plunkettThanks @quietone