Add More Embedding Options

You already opened #2861425: More Embedding Options.

I don't think modest branding is an option for vimeo? This is not a feature that is common across all providers, so it doesn't belong in the plugin interface. We've leaned towards really easy programatic overrides instead of providing every option for every provider, hence the description in the linked issue.

Please see the reasoning in #2635576: Consider deprecating the concept of 'Video Styles' for 8.x to not do this. At this stage I consider it outside the 80% use case and thus a "wont fix".

As an alternative, "enable modest branding by default" would be something to consider.

By saying:

enable modest branding by default

I meant, specifically keep it out of the interface, but make it the default behaviour for the youtube provider.

Patch #8 works for me (D8.5). I just had to change one thing to make it work with Video Embed WYSIWYG:

Change video_embed_field/modules/video_embed_wysiwyg/src/Plugin/Filter/VideoEmbedWysiwyg.php:91

$embed_code = $provider->renderEmbedCode($embed_data['settings']['width'], $embed_data['settings']['height'], $autoplay);

to

$embed_code = $provider->renderEmbedCode($embed_data['settings']['width'], $embed_data['settings']['height'], $autoplay, $embed_data['settings']['showinfo'], $embed_data['settings']['controls'], $embed_data['settings']['modestbranding']);

Hi - I have a need to not display the title of only one of many embedded videos on a site. This update would be very useful for me. Any idea when it might be released? I do know that &showinfo is deprecated since September of 2018.

Thanks,

Cheryl

I needed this for a site where folks are embedding Vimeo and getting a bunch of junk they don't want to see.

Re-rolled for 8.x-2.x branch.
Added 'portrait' to the query that we generate to turn off the Vimeo smiley face, too. ;)

I don't expect the maintainers to commit this anytime soon, but I'm uploading here so I can safely deploy via composer for now...

Cheers,
-Derek

I have indeed marked the module as "Maintenance fixes only", since it's functionality is almost entirely supported by core now.

Yeah, I was actually shocked when I realized/discovered the site was still using this module. ;) It's now on a TODO list to migrate to core's video field, but for now, I just needed a quick/dirty solution to make them happy.

Thanks for your work on this and sorry for the noise,
-Derek

No problem at all, hopefully you get it all sorted. Good luck.

Also as a side note, I've updated the project page with a fairly in-ya-face warning, which should hopefully reduce the number of new sites that choose to use it.

Re-roll of #13 with a fix for Youtube autoplay. Legacy code...

Tried patch #18 and found it worked fine for adding new embeds but breaks existing ones.
This is because it tries to validate the default settings, however the old embeds don't have these settings.
Have made some changes so that the new settings are not required.

Edit: Sorry attached the wrong patch, see below.

With the advent of Media in core, the Video Embed Field module has moved to being minimally maintained. Only issues which assist in the migration to Media in core will be committed. To read more about this decision, please see: #3089599: Maintenance status for Video Embed Field now that media is in core.

add the new patch For Mute the Video.

Re-roll of #22 For Solve the error