Random fail in Drupal\aggregator\Tests\FeedAdminDisplayTest::testFeedUpdateFields [#2861067]

Comment	File	Size	Author
#5	2861067-5.patch	782 bytes	Anonymous (not verified)
8.4.x: PHP 5.6 & MySQL 5.5 21,866 pass
#3	pseudorandom-2861067-3-fail.patch	1.17 KB	Anonymous (not verified)
8.4.x: PHP 5.6 & MySQL 5.5 4 pass, 1 fail

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 16 March 2017 at 08:27

vaplas created an issue. See original summary.

Log in or register to post comments

Comment #2

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 11 April 2017 at 18:44

Issue summary:

View changes

This also happened in HEAD (last March 11): https://www.drupal.org/pift-ci-job/619499

Log in or register to post comments

Comment #3

Anonymous (not verified) CreditAttribution: Anonymous commented 16 April 2017 at 17:34

Status:

Active

» Needs review

File	Size
pseudorandom-2861067-3-fail.patch	1.17 KB
8.4.x: PHP 5.6 & MySQL 5.5 4 pass, 1 fail

Aha! What if just the randomMachineName() is generating value with 'ago' from time to time?

The patch reproduces this fail in 49 line :)

Log in or register to post comments

Comment #4

16 April 2017 at 17:39

Status:

Needs review

» Needs work

The last submitted patch, 3: pseudorandom-2861067-3-fail.patch, failed testing.

Log in or register to post comments

Comment #5

Anonymous (not verified) CreditAttribution: Anonymous commented 16 April 2017 at 18:18

Status:

Needs work

» Needs review

File	Size
2861067-5.patch	782 bytes
8.4.x: PHP 5.6 & MySQL 5.5 21,866 pass

This code confirms the fact that sometimes this can happen:

$i = 0;
while (++$i) {
  $this->assertSame(FALSE, strpos($this->randomMachineName(10), 'ago'), $i);
}

Quick solution - just override randomMachineName().

Log in or register to post comments

Comment #6

dawehner

German

CreditAttribution: dawehner as a volunteer commented 16 April 2017 at 18:42

Status:

Needs review

» Reviewed & tested by the community

This catch!

Log in or register to post comments

Comment #9

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 17 April 2017 at 13:55

Version:	8.4.x-dev	» 8.3.x-dev
Status:	Reviewed & tested by the community	» Fixed
Related issues:		+#2571183: Deprecate random() usage in tests to avoid random test failures

Committed/pushed to 8.4.x, and cherry-picked to 8.3.x, thanks!

I was going to ask for a more generic solution, but I think the more generic solution is #2571183: Deprecate random() usage in tests to avoid random test failures and that's still under discussion. So just adding it as a related issue.