Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Kickstart. The Tender alignment of the EOD Report should stay static. Cash-Credit-Debit-Gift Card as an example. Even if only one Tender has been used, all should show up, even as zeros. It has changed today where if you have used the tender type, it will show up in EOD. If you haven't used it, it doesn't show up at all. It is also adding them in order of first use.
Again, this should be a static list to avoid confusion.
There is also an alignment issue - in Reports section, Transaction date and Register are not lined up. Just a cosmetic issue but an issue nonetheless.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | eod-report-tender-order-2860922-9.png | 9.53 KB | cbildstein |
| #9 | eod-report-tender-order-2860922-9.patch | 3.76 KB | cbildstein |
| #7 | pos_report_register_alignment.png | 20.12 KB | cbildstein |
| #6 | align.JPG | 18.45 KB | fergy |
| #4 | Screen Shot 2017-03-29 at 10.53.36 PM.png | 198.77 KB | Anonymous (not verified) |
Comments
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedI took a stab at this here: https://github.com/AcroMedia/commerce_pos/pull/19
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedHere's the patch.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedAnd here's a screenshot
Comment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedI took a stab at fixing the alignment issue, but I'm not really sure which approach is best. The first element (Transaction Date) is a date_select element, and they have their own styling (inline styling). The Register element is a plain select element, which doesn't have the same spacing.
There are a few options here:
1. Add CSS to the module to try and make them align.
This isn't ideal because that CSS probably won't play well with different themes. We can make it look good in one theme, but that might mess up other themes.
2. Put the Register element on a newline.
Not ideal because more space is needed for the filters.
3. Add CSS to the commerce_kickstart theme that fixes it.
Only fixes it for one theme.
I'm not really sure which I like best, but I'm leaning towards 2 right now.
Comment #6
fergy CreditAttribution: fergy commentedComment #7
cbildstein CreditAttribution: cbildstein at Acro Commerce commentedI would suggest removing the custom style overrides from the module file "commerce_pos_report.css", selectors: ".form-item-filters-register, .form-item-register-id".
And then removing the "Transaction Date" label from the "container-inline-date" field and adding a label/header above the field so it would play nice with most themes and rely less on having override styles in the module.
Comment #8
smccabe CreditAttribution: smccabe as a volunteer and at Acro Commerce commentedComment #9
cbildstein CreditAttribution: cbildstein at Acro Commerce commentedI made the Transaction Date title invisible and created a header above the date as a separate form-item so it stays above the inline date field and register form item.
Added some CSS to force margins/padding in that area since there's too many overrides that could take place across themes and it should look decent with consistent margins/padding for those form items in that one area.
Changes for both EOD and Journal Role.
New patch attached.
Comment #11
smccabe CreditAttribution: smccabe as a volunteer and at Acro Commerce commented