Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
We need this before release.
Comment | File | Size | Author |
---|---|---|---|
#4 | 2860816-3.patch | 500 bytes | swentel |
#3 | 2860816-2.patch | 500 bytes | swentel |
Comments
Comment #2
swentel CreditAttribution: swentel as a volunteer commentedComment #3
swentel CreditAttribution: swentel as a volunteer commentedComment #4
swentel CreditAttribution: swentel as a volunteer commentedComment #7
swentel CreditAttribution: swentel as a volunteer commentedTested this locally, seems to work fine. Not sure if we'd want an upgrade path test for this ...
Comment #8
swentel CreditAttribution: swentel as a volunteer commentedSo we probably should also test the branch version of panels which should be 8.x-4.x ?
Comment #9
aspilicious CreditAttribution: aspilicious commentedWe shouldn't do this line, as we are not the only module using this.
+ \Drupal::service('module_installer')->uninstall(['layout_plugin'], FALSE);
Instead we should throw a message during update.
Comment #10
swentel CreditAttribution: swentel as a volunteer commentedWell you can't install both (layout_discovery has a requirement check) so there needs to be an uninstall anyway.
Panels 8.x-4.x uses layout_discovery, so we need to align anyway.
setting back to to get more eyes on it :)
Comment #11
aspilicious CreditAttribution: aspilicious commentedYeah seems fine to commit in that case.
Comment #12
swentel CreditAttribution: swentel as a volunteer commentedKeeping it at needs review to get more reviews, pinging more people.
Adding #2833976: How Panels, Display suite, Layout Plugin, Layout Discovery and core get to a stable layout plugin in core as related.
Comment #13
swentel CreditAttribution: swentel as a volunteer commentedComment #14
goldlilys CreditAttribution: goldlilys as a volunteer commentedNot sure if this is compatible with Bootstrap Layouts https://www.drupal.org/project/bootstrap_layouts either to use for Display Suite since it's causing this error when I enable some Bootstrap classes:
The website encountered an unexpected error. Please try again later.
Error: Call to undefined method Drupal\bootstrap_layouts\Plugin\Layout\BootstrapLayoutsBase::getRegionNames() in Drupal\bootstrap_layouts\Plugin\Layout\BootstrapLayoutsBase->submitConfigurationForm() (line 231 of modules/contrib/bootstrap_layouts/src/Plugin/Layout/BootstrapLayoutsBase.php).
I'm not fully sure what is causing this error, but somehow the Bootstrap Layout is using this new Layout Discovery with Display Suite. It worked on the previous version of Core, DS and Bootstrap Layout, but after needing to upgrade the core to 8.3 for the Calendars Event Date Range to work, this Display Suite started to not work and causing errors.
Comment #15
aspilicious CreditAttribution: aspilicious commentedGoldlilys, can you tell use what branch you're on (for display suite?)
Comment #16
swentel CreditAttribution: swentel as a volunteer commentedYou probably also want to have the 8.x-5.x branch of bootstrap layouts.
Comment #17
swentel CreditAttribution: swentel as a volunteer commentedSo given that, checking for other modules is kind of pointless, so will commit this soon.
Comment #19
swentel CreditAttribution: swentel as a volunteer commentedpushed, will release alpha 2 now.
Comment #21
EdPhillis CreditAttribution: EdPhillis commentedI upgraded core to 8.3 which broke my layouts. Im using Bootstrap layouts so upgrading that module to 5-dev as suggested which brought me to this issue as I have display suite installed as well. DS requires Layout Plugin so Im guessing I will need to uninstall DS, apply this patch and re-install. Is that correct? At the moment I cant get to uninstall screen because of this issue but i think i should be able to do it with drush..
Comment #22
karenann CreditAttribution: karenann as a volunteer commentedRunning drush cim in my env results in:
Comment #23
borisson_@#22
Layout Discovery
is the core module that's needed for layouts, you shouldn't try to uninstall that one. Are you sure that you did acex
after runningupdb
? It looks like you didn't.To make sure that installing works again, edit
config/core.extension.yml
and addlayout_discovery: 0
to the modules before importing again.