Add orderby key to third party settings

Looks like you included a .gz file as well while creating patch. Leading to such content in the patch.

ÈX�drupal-8.3.x.bare-standard-plus-config_test.php�ì½Û–ÛF–(ø0oõ˜\g–í!…û%åv—,Y¶ºtkKvµûäY\ 	‹$h€””.k­óóógæíÌŸœ/™Øq@€I™’Ù«ZNâˆØ{ÇŽ}ß_ÿëâzñ—û÷µ¿Åy’ͯ^/Ñ<AER>½šç~’Mñ_îÿõ¯Ñþªý-…䏇Z‚–(B%Öyª\f±–¬f-Ím‰Éïù•¶X‹¼Äå9y^zs•Œ ½G¥v…ç¸@Kœhэ¶¼ÆÚãbµ@S-87´$Ò—y>-ÏÉÌ´2.²Å¹ÿ—¿¬Jñàå#2¹ËÇ|Õþò—ÿçó9Ž—Y>×þE7..®ðòQuç˯šOêß”ñ5ž¡/¿Ò¿‰L&öESüåZÆ×_ÜÓPQ ›/ÿ¢i_¤ž&åÚ¿|S_$—£,i_#W—7L/‘Í—_Ü—çùR›¯¦Szë͏?}WÝ)³ßùú34­ßYÍËìjŽ“Ö;_±ÿ|±ÌßâùÚ¼CE|Š	*ã,2—)ž_-¯ÙËžóEë{ÙŒ Í\µøCºïDÓ<êùГ‡Ï^«¾eWògè?_,Šl†Ší-¾Qb¸~2›'øîÒA/èõÎg7åoÓ	àÅK\LJ¼dÓ[-Ó`Ô¿L«Ó<~;!.1€}3Ín Ù™L Ú¿ËJ²¦É맽Ûnñ©ƒìÛjQôjµaÁ{}δ‚Ö÷¦h~Eøû—hZÛí¦ÆfZͳßVžS0V™ª'”’'€ßdòMWª%Qè¶XHc”Ézº“ïvÕ·ñ•óà’QANŸ54~<¶0™Dyr3è@[Í“éA	&¨_IpŠVS¾Æê<ÅK<òéJD”›žÏ­ï¨eË›Ý9Ô]á”ãÌãðœ¤b–›éb‰n°•z™P=%þ°å<Z²‰øT¹š?Ýõc%!ñµ€±ÜÏͯʈ¶\w»3£Þ‰-ÖÐ ˆ6¡`Ý}¬ŽßØf'öœ*ß=âqÀÎ)PçFÿ,<ðÈÂâ±…7ºSÒ|ÈçöÝóä.f~µóñ>HüïÐϲ@órŠ`ŸLPš’3ú$£>°èa6„Ï}$šíDð-yeSš1¼½®ÉºVU¤&™æ•1¥øOGTgË8ñç;$£žæŸ‘av9ʧÁ9ͨ>CuÛç-p©jõ+²¾C2-Áèê¸ìlš_X‰Þž™lÉ<Ö1ˆµrNƒÖ<Mr¹†r²VvŽªöçOÖÊ“µr,NÖÊ[¶V*ÄÇ“sû£"Fä:9òeIԒŐÓ!>¤·µ&Œ�ÀÉæb+t7&µ¾®›ÞþÑ
@ŽY1²

+++ b/core/modules/system/tests/fixtures/update/drupal-8.config-resave.php
@@ -0,0 +1,30 @@
+ * Partial database to configuration that will be affected by re-saving.

s/to/with ?

@gaurav.kapoor : that's intented - that's how you can add a large dump of a db which will be imported for upgrade tests.

thanks for info @swentel.

AFAICT this patch was just waiting to be RTBC'd, unfortunately I only discovered it now :(

+++ b/core/modules/system/src/Tests/Update/ResaveConfigurationTest.php
@@ -0,0 +1,36 @@
+ * Tests system_post_update_resave_configuration().
...
+class ResaveConfigurationTest extends UpdatePathTestBase {

+++ b/core/modules/system/system.post_update.php
@@ -65,3 +65,30 @@ function system_post_update_hashes_clear_cache() {
+function system_post_update_resave_configuration(&$sandbox = NULL) {

It's not just about resaving configuration, it's about resaving configuration to ensure correct sorting.

So "ResaveConfigForCorrectSorting" or something like that would make more sense. Because "resave config" is something that's likely to happen again in the future.

Other than that, I think this looks totally ready! I do think this will need a change record though, because it'll cause config managed via git to be changed for existing sites.

Re-rolled patch.

Re-rolled patch (ignore patch from #24)

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Reeolled.

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

moving to NW for change record.

Added a CR. Back to rtbc.

@ameymudras thanks for working on this. Please include interdiffs though to easily see the changes.

+ $config_factory->getEditable($config_name)->save(TRUE);
Seems to address #35

Since this was previously RTBC going to restore but do wonder about

unset($sandbox['config_names'][$key]);

Removing the needs CR tag,