With #2666584: [Community Initiative Proposal] Project Applications Process Revamp more people can create full releases. Everyone, vetted or not, could use a reminder about what 1.0 means:

  • Creating any release locks the tag in place. Are you sure?
  • 1.0 means stable. Grab some words from Drupal.org or Semver standard.
  • If the project is covered, yay, your release will be covered. Otherwise, you should look into coverage.
CommentFileSizeAuthor
#4 Screen Shot 2017-03-22 at 4.26.21 PM.png67.01 KBdrumm
#4 Screen Shot 2017-03-22 at 4.26.06 PM.png83.57 KBdrumm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drumm created an issue. See original summary.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Assigned: Unassigned » drumm
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented

The copyediting I have so far is:

When making any tagged release:

Tagged releases are permanent, please double check what is in your release. If you notice a problem after making this release, you can release the next version.

When making a full tagged release:

Full releases mean stable and ready for general use. Upgrade paths between stable releases should be provided. It is a good idea to make a alpha, beta, and/or RC releases before the full release. Read more about Drupal’s release naming conventions

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Active » Needs review
FileSize
Screen Shot 2017-03-22 at 4.26.06 PM.png83.57 KB
Screen Shot 2017-03-22 at 4.26.21 PM.png67.01 KB

Non-covered project release hitting all the messages:
Screenshot

Covered project release hitting all the messages:
Screenshot

The messages reveal themselves when relevant tags are selected. Projects I’ve been testing with are:

You can reload the page and test from scratch as long as you don’t save the node on the second screen.

A starting point for finding other orphan tags for testing is SELECT vl.*, n.nid, n.title FROM versioncontrol_labels vl INNER JOIN versioncontrol_project_projects vpp ON vpp.repo_id = vl.repo_id INNER JOIN node n ON n.nid = vpp.nid LEFT JOIN versioncontrol_release_labels vrl ON vrl.label_id = vl.label_id WHERE vrl.label_id IS NULL AND vl.type = 3 AND vl.name LIKE '8.x-%.0' LIMIT 10; Or, you can delete a release on dev and try creating a replacement.

mlhess’s picture

mlhess CreditAttribution: mlhess as a volunteer commented
Status: Needs review » Reviewed & tested by the community

I like this, we may want to revisit some of the text at some point, however, that would be a much lower priority issue.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented

One last change - I realized the error message does not offer a path forward. I added this:

You must confirm you want to make a full release without security advisory coverage. Until a project has security advisory coverage, it is recommended to only make pre-release versions.

This ended up being quite a bit of logic. I'll plan on deploying tomorrow AM.

  • drumm committed c938121 on 7.x-3.x 
    Issue #2860311 by drumm: Remind maintainers what a full release is when...
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Reviewed & tested by the community » Fixed

This has been deployed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.