I'm testing out easy PAReview.sh support inside Drupal VM (see: https://github.com/geerlingguy/drupal-vm/issues/1197), and I found a few easily-correctable errors that I'd like to fix :)

CommentFileSizeAuthor
#12 2860293-12.patch20.27 KBgeerlingguy
#10 2860293-10.patch19.72 KBgeerlingguy
#8 2860293-8.patch19.55 KBgeerlingguy
#6 2860293-6.patch19.42 KBgeerlingguy
#4 interdiff.txt3.25 KBgeerlingguy
#4 2860293-4.patch18.91 KBgeerlingguy
#3 2860293-3.patch16.85 KBgeerlingguy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

geerlingguy created an issue. See original summary.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Acquia commented

Master branch deleted as instructed here: https://www.drupal.org/node/1127732

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Acquia commented
Status: Active » Needs review
FileSize
2860293-3.patch16.85 KB

Attached patch fixes 95% of things (almost all completely harmless changes).

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Acquia commented
FileSize
2860293-4.patch18.91 KB
interdiff.txt3.25 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2860293-4.patch, failed testing.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Acquia commented
Status: Needs work » Needs review
FileSize
2860293-6.patch19.42 KB

Fixes.

Status: Needs review » Needs work

The last submitted patch, 6: 2860293-6.patch, failed testing.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Acquia commented
Status: Needs work » Needs review
FileSize
2860293-8.patch19.55 KB

D'oh, forgot a 'use'.

Status: Needs review » Needs work

The last submitted patch, 8: 2860293-8.patch, failed testing.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commented
Status: Needs work » Needs review
FileSize
2860293-10.patch19.72 KB

And need to actually get the module handler... (this is what I get for just blindly editing a plain text file in nano without testing any code :D).

Status: Needs review » Needs work

The last submitted patch, 10: 2860293-10.patch, failed testing.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commented
Status: Needs work » Needs review
FileSize
2860293-12.patch20.27 KB

Finally decided to actually do some debugging while using the module, so I'm pretty sure I've tidied everything up finally.

geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commented
Status: Needs review » Reviewed & tested by the community
geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy at Midwestern Mac, LLC commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x!

  • geerlingguy committed a530b13 on 8.x-1.x 
    Issue #2860293 by geerlingguy: Fix some PAReview.sh suggestions

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Issue tags: -pareview, -drupalvm