Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hello,
I am hereby asking for my contributed module to be reviewed.
Name: b2share
Description: This module allows to interact with the H2020 EUDAT file repository "b2share". It incorporates curl and communicates with an external REST API. Additional information is provided on the project page.
Intended drupal core version: 7.x
(I already promoted it to a full project, so a link to the sandbox project doesn't exist anymore)
git clone --branch 7.x-1.x http://git.drupal.org/project/b2share.git
Comment | File | Size | Author |
---|---|---|---|
#6 | coder_review.png | 1.82 MB | Yogesh Kushwaha |
Comments
Comment #2
PA robot CreditAttribution: PA robot commentedGit clone command for the sandbox is missing in the issue summary, please add it.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
stopopol CreditAttribution: stopopol commentedComment #4
stopopol CreditAttribution: stopopol commentedComment #5
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectb2sharegit
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #6
Yogesh Kushwaha CreditAttribution: Yogesh Kushwaha at Kellton Tech Solutions Ltd commentedi have attached coder review report, please fix these issues.
Comment #7
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #8
stopopol CreditAttribution: stopopol commentedI fixed the issues that you mentioned. Thank you for the feedback. I don't know how to fix the one remaining git error. Everything else should be ok. Sorry about the delay.
Comment #9
sleitner CreditAttribution: sleitner commentedAutomated Review
Pareview details: https://pareview.sh/pareview/http-git.drupal.org-project-b2share.git/rev...
Git errors:
Review of the 7.x-1.x branch (commit f12b454):
hook_help()
. See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .This automated report was generated with PAReview.sh, your friendly project application review script.
Manual Review
version = "7.x-1.0"
from b2share.info,. The version string will be added by drupal.org when a release is created and a tarball packaged: https://www.drupal.org/docs/7/creating-custom-modules/writing-module-inf...is not nessessary, these two files are loaded by default.
Notice: Undefined index: collapsed in b2share_field_widget_form() (line 283 of /home/dfe6d/www/sites/default/modules/b2share/b2share.module).
Notice: Undefined index: collapsible in b2share_field_widget_form() (line 278 of /home/dfe6d/www/sites/default/modules/b2share/b2share.module).
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #10
apadernoIf you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.
I am closing this application due to lack of activity.