Hello,
I am hereby asking for my contributed module to be reviewed.

Name: b2share
Description: This module allows to interact with the H2020 EUDAT file repository "b2share". It incorporates curl and communicates with an external REST API. Additional information is provided on the project page.
Intended drupal core version: 7.x

(I already promoted it to a full project, so a link to the sandbox project doesn't exist anymore)
git clone --branch 7.x-1.x http://git.drupal.org/project/b2share.git

https://www.drupal.org/project/b2share

CommentFileSizeAuthor
#6 coder_review.png1.82 MBYogesh Kushwaha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stopopol created an issue. See original summary.

PA robot’s picture

Status: Active » Needs work

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

stopopol’s picture

Title: B2Share Security test » [D7] B2Share implementation module
Issue summary: View changes
stopopol’s picture

Status: Needs work » Needs review
PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectb2sharegit

I'm a robot and this is an automated message from Project Applications Scraper.

Yogesh Kushwaha’s picture

FileSize
1.82 MB

i have attached coder review report, please fix these issues.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

stopopol’s picture

Status: Closed (won't fix) » Needs review

I fixed the issues that you mentioned. Thank you for the feedback. I don't know how to fix the one remaining git error. Everything else should be ok. Sorry about the delay.

sleitner’s picture

Status: Needs review » Needs work

Automated Review

Pareview details: https://pareview.sh/pareview/http-git.drupal.org-project-b2share.git/rev...

Git errors:

  • The following git branches do not match the release branch pattern, you should remove/rename them. See https://www.drupal.org/node/1015226
      7.x-1.0
      remotes/origin/7.x-1.0
      remotes/origin/HEAD -> origin/7.x-1.0
    

Review of the 7.x-1.x branch (commit f12b454):

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template. See pareview details
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
No: List of security issues identified.security requirements: please use filter_xss for form input fields!
Coding style & Drupal API usage
  1. (*) remove version = "7.x-1.0" from b2share.info,. The version string will be added by drupal.org when a release is created and a tarball packaged: https://www.drupal.org/docs/7/creating-custom-modules/writing-module-inf...
  2. (+) I believe
    files[] = b2share.module
    files[] = b2share.install

    is not nessessary, these two files are loaded by default.

  3. (*) Notices are thrown when add field to content type: Notice: Undefined index: collapsed in b2share_field_widget_form() (line 283 of /home/dfe6d/www/sites/default/modules/b2share/b2share.module).
  4. Notice: Undefined index: collapsible in b2share_field_widget_form() (line 278 of /home/dfe6d/www/sites/default/modules/b2share/b2share.module).

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

apaderno’s picture

Status: Needs work » Closed (won't fix)

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.