All coding standards were fixed en mass last year, but there was not a sniff for some standards.

A large majority of our existing coding standards violations are attributed to incorrect casing for TRUE/FALSE/NULL. in doc comments.

Other violations are a mish mash of other standards. Lets fix these first.

CommentFileSizeAuthor
#2 bool-null-type-doc-casing-2859786.patch21.12 KBdpi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Title: Fix boolean||NULL types in function definitions » Fix casing of bool||NULL types in function definitions
Status: Active » Needs review
FileSize
bool-null-type-doc-casing-2859786.patch21.12 KB

Sniff Drupal.Commenting.FunctionComment.

PR https://github.com/dpi/smsframework/pull/67

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs review » Reviewed & tested by the community

Looks good

  • dpi committed d355b16 on 8.x-1.x 
    Issue #2859786 by dpi, almaudoh: Fixed casing of bool|null types in...
dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Patch has no conflicts after #2836157: DeliveryReports should be storable.

Committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.