The current JavaScript used to create Chosen instances via Drupal behaviors is not performant and lacks modularization and extensibility.

Will provide patches for both 8.x and 7.x shortly.

CommentFileSizeAuthor
#10 interdiff-2859781-4-10.txt422 bytesmarkhalliwell
#10 optimize_javascript-2859781-7.x-10.patch7.92 KBmarkhalliwell
#5 optimize_javascript-2859781-4-7.x.patch7.95 KBmarkhalliwell
#4 interdiff-2859781-7.x-2-4.txt516 bytesmarkhalliwell
#4 optimize_javascript-2859781-7.x.patch7.64 KBmarkhalliwell
#4 optimize_javascript-2859781-4-8.x.patch8.17 KBmarkhalliwell
#2 optimize_javascript-2859781-7.x.patch7.64 KBmarkhalliwell
#2 optimize_javascript-2859781-8.x.patch7.72 KBmarkhalliwell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markcarver created an issue. See original summary.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Active » Needs review
FileSize
optimize_javascript-2859781-8.x.patch7.72 KB
optimize_javascript-2859781-7.x.patch7.64 KB
nagy.balint’s picture

nagy.balint CreditAttribution: nagy.balint commented

Hi!

Thanks for the patch!

Can you integrate this commit? http://cgit.drupalcode.org/chosen/commit/?id=0cbc043

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
FileSize
optimize_javascript-2859781-4-8.x.patch8.17 KB
optimize_javascript-2859781-7.x.patch7.64 KB
interdiff-2859781-7.x-2-4.txt516 bytes
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
FileSize
optimize_javascript-2859781-4-7.x.patch7.95 KB

Ugh, wrong 7.x patch... sorry.

nagy.balint’s picture

nagy.balint CreditAttribution: nagy.balint commented

Thanks!

I committed the d8 version first.

There was a typo at three places, drupalSsettings instead of drupalSettings.

Otherwise the code worked for me for what i tried, but we can wait in dev if it works on the long term as well.

nagy.balint’s picture

nagy.balint CreditAttribution: nagy.balint commented
nagy.balint’s picture

nagy.balint CreditAttribution: nagy.balint at Agence Inovae commented
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Version: 8.x-2.x-dev » 7.x-2.x-dev
FileSize
optimize_javascript-2859781-7.x-10.patch7.92 KB
interdiff-2859781-4-10.txt422 bytes

Hm. Not sure how this erroneous line got into the 7.x patch. Here's an updated version of the patch.

nagy.balint’s picture

nagy.balint CreditAttribution: nagy.balint at Agence Inovae commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.