Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Follow-up from: #2850608: Basic fundamental paragraph types implementation
We deleted dependency on paragraphs_demo from paragraphs_collection_demo. Lets check which types we are missing now and discuss if we want to add them.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#14 | identify_which_types_we-2859509-14.patch | 9.74 KB | Ginovski |
| |||
#14 | interdiff-2859509-12-14.txt | 8.9 KB | Ginovski |
#12 | identify_which_types_we-2859509-12.patch | 9.54 KB | Ginovski |
| |||
#12 | interdiff-2859509-10-12.txt | 8.03 KB | Ginovski |
#10 | identify_which_types_we-2859509-10.patch | 8.71 KB | Ginovski |
|
Comments
Comment #2
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedWe are missing:
-Text + Images
-Images + Text
-User
-Nested paragraph (but we have Container instead)
Adding patch with the 3 missing types (Text + Images, Images + Text, User) if we want to add them.
Comment #3
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedIMHO we don't need both T + I and I +T any more. I think having I + T is enough for now. I am also not sure if we want the User.
Comment #4
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedAdded only I+T
Comment #5
toncic CreditAttribution: toncic at MD Systems GmbH commentedWe can delete all of these.
Comment #6
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedAddressed comment #5.
Comment #7
toncic CreditAttribution: toncic at MD Systems GmbH commentedNeeds reroll, and try to install pc. We got some error about unmet dependencies.
Comment #8
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedRerolled, fixed fields.
Comment #9
miro_dietikerThe account paragraph type is an important concept to display an author profile.
Author profiles are known to be pretty specific though...
Still, i think it's important that the collection also contains examples of references to other entities so they can be placed in Paragraphs.
Comment #10
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedAdded the user and added an example user in the paragraphs_collection_demo.
Comment #11
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedWe probably don't need the label to be visible in any of the fields.
svg?
Maybe we can leave the alt field as optional
I think we are aiming for the field names to be prefixed by paragaraphs_ .... although we are not doing a good job at that.
We have a special page for fundamental types I think.
Also do we want to add demo content for other fundamental types from this patch too?
Comment #12
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedAddressed #11.
1. Made the label hidden for the fields.
2. Added svg to the fiel extensions for images.
3. Made the alt field in the images optional
4. Changed fields names to be prefixed with paragraphs
5. Moved the user paragraph to the page for fundamental types and added an images+text paragraph content aswell.
Comment #13
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedLet's not make this unlimited.
I think we are setting the field cardinalities to 1 in #2863568: Fix cardinality and label display of the fields in fundamental types so we might want to rename this to Image + Text
I also noticed that in demo the user field value is not set. Probably because you use current user which is 0 when installing via drush I think. Just user uid 1.
Comment #14
Ginovski CreditAttribution: Ginovski at MD Systems GmbH commentedAddressed #13 comment.
Comment #16
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedCommitting this so that we can change the images field name in #2863568: Fix cardinality and label display of the fields in fundamental types. Thanks.