I'm testing drupal 8.3.x and I discovered that any content entity that extends ContentEntityForm needs modifications to be compatible with core.

The exact error is:

Error: Call to a member function getRequestTime() on null a Drupal\Core\Entity\ContentEntityForm->updateChangedTime() line 373

When you try to save a Config page form because Content Entity Forms now use the new datetime.time service.

I did not find a way to make it compatible with both versions of Drupal core and the modules I looked at they all changed their construct() and create() methods to accommodate the changes in core.

So I feel is time for a new version of this module that has compatibility with newer versions of core. 8.x-2.x

CommentFileSizeAuthor
#2 2859149-Drupal-8-3-compatibility-2.patch2.98 KBrodrigoaguilera
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rodrigoaguilera created an issue. See original summary.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
CreditAttribution: rodrigoaguilera as a volunteer and at Ymbra commented
Status: Active » Needs review
FileSize
2859149-Drupal-8-3-compatibility-2.patch2.98 KB

Here is my try at solving the issue. It needs to call the parent class to fill the time service.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented

Hello,

I also encountered the same fatal error testing the module against Core on 8.3.0-rc2, config_pages 8.1.0-rc5 and applying the patch solved the bug.

I did not make any code review.

Thanks @rodrigoaguilera

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
CreditAttribution: rodrigoaguilera at Ymbra commented
Priority: Normal » Major

Drupal 8.30 is around the corner. Can we have this reviewed?

M@ster’s picture

M@ster CreditAttribution: M@ster commented

Works fine for me, tnx.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
CreditAttribution: rodrigoaguilera at Ymbra commented

@shumer I can help with maintenance of the D8 branch if you are up for it

shumer’s picture

shumer CreditAttribution: shumer as a volunteer commented
Assigned: Unassigned » shumer

New branch was added, and new RC released.
Thx for this fix.

shumer’s picture

shumer CreditAttribution: shumer as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.