Undefined property the query name on row [#2859127]

In the latest dev there is for each entity a notice that the $row doesn't contain the property named after $info['query_name']. That field is indeed not set and the field can only be retrieved from the entity.

Drupal version: 8.2.6.

$item_start_date = \DateTime::createFromFormat($storage_format, $row->{$info['query_name']});
$item_end_date = \DateTime::createFromFormat($storage_format, $row->{$info['query_name']});

Comment	File	Size	Author
#7	calendar-row_undefined_property-2859127-7.patch	1.26 KB	stomusic
#7
#3	calendar-row_undefined_property-2859127-3.patch	1.27 KB	_Archy_
#3
#2	calendar-row_undefined_property-2859127-2.patch	1.27 KB	_Archy_
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

9 March 2017 at 09:42

_Archy_ created an issue. See original summary.

Comment #2

_Archy_ CreditAttribution: _Archy_ at PitechPlus commented 9 March 2017 at 09:48

File	Size
calendar-row_undefined_property-2859127-2.patch	1.27 KB

Without much knowledge of the module's code I am adding this simple fix. Don't know the implications, but seems to work for my case.

Comment #3

_Archy_ CreditAttribution: _Archy_ at PitechPlus commented 9 March 2017 at 09:55

File	Size
calendar-row_undefined_property-2859127-3.patch	1.27 KB

1 file was hidden/shown/deleted

File	Size
calendar-row_undefined_property-2859127-2.patch	1.27 KB

Wrongly created patch.

Comment #4

mmbk

German

Meißen

CreditAttribution: mmbk commented 9 March 2017 at 13:33

I have had the same problem, and confirm that the patch is working.
It is located at the same codelines, where I just submitted a report

Comment #5

mmbk

German

Meißen

CreditAttribution: mmbk commented 10 March 2017 at 06:27

Hmm, I justed wonder why the date field is fetched from the row instead of the entity.
The views-template is based on an entity's date field. So this field must exist in the entity, so I see no need for using the row. Furthermore the FieldDefinition() is queried from the entity, there it is already asumed that the field exists in the entity.

Edit:
OK, I found the reason why the row field has to be used, as soon as the field's cardinality is not 1, the entity-field will fetch the wrong values. As far as I see the actual delta is not accessible, so the row-value has to be used.