Open branch that supports layout_discovery instead of layout_plugin

Hi mattlt, this is actually a very good idea, thanks!

Hi,

any progress on this?
D 8.3 is out using the new plugin.
Still using the layout plugin instead of the discovery plugin has become a show stopper.

thanks!

Hi Mat, sorry for delay, unfortunately have not enough time to work on it right now, but I'm happy to review and apply patches if anybody can help with it.

Lovely module & idea for exposed filter theming. Please find a patch attached which removes support for layout plugin and adds support for layout discovery. Additionally, some minor refactoring done to the vefl helper class should make writing tests more approachable.

As already stated above, this should go into a 8.x-2.x branch due to the removal of layout plugin.

Great swim! Thanks for your help, will review it soon.
Testing/reviewing from someone also will be appreciated too.

A bit of clean-up. Only 8.3 has both modules so no reason to point version

PS: using this patch found no issues

Hi,
after apllying the patch #7 I've this error:
The website encountered an unexpected error. Please try again later.
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "vefl.layout" has a dependency on a non-existent service "plugin.manager.core.layout". in Symfony\Component\DependencyInjection\Compiler\CheckExceptionOnInvalidReferenceBehaviorPass->processReferences() (line 58 of /var/www/macchinece/vendor/symfony/dependency-injection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php).

Symfony\Component\DependencyInjection\Compiler\CheckExceptionOnInvalidReferenceBehaviorPass->processReferences(Array) (Line: 42)
Symfony\Component\DependencyInjection\Compiler\CheckExceptionOnInvalidReferenceBehaviorPass->processDefinition(Object) (Line: 36)
Symfony\Component\DependencyInjection\Compiler\CheckExceptionOnInvalidReferenceBehaviorPass->process(Object) (Line: 104)
Symfony\Component\DependencyInjection\Compiler\Compiler->compile(Object) (Line: 598)
Symfony\Component\DependencyInjection\ContainerBuilder->compile() (Line: 1299)
Drupal\Core\DrupalKernel->compileContainer() (Line: 883)
Drupal\Core\DrupalKernel->initializeContainer() (Line: 465)
Drupal\Core\DrupalKernel->boot() (Line: 655)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

You need to enable core module *layout_discovery*

ah! ok thank you

Thank you andypost, skorzh and mattlt!

This issue has been resolved and a new branch for vefl which supports layout discovery has been published. Please see, https://www.drupal.org/project/vefl/releases/8.x-2.x-dev.

Now this is sorted a nice to have would be testsss =D.