When running functional tests with features enabled we receive the following errors:

Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for features.bundle.default with the following errors: features.bundle.default:assignments.alter.core missing schema, features.bundle.default:assignments.alter.uuid missing schema, features.bundle.default:assignments.alter.user_permissions missing schema

The module also fails when usinng the config inspector module. Screen shot of config inspector output is attached.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsjordan created an issue. See original summary.

dsjordan’s picture

Assigned: Unassigned » dsjordan
Status: Active » Needs review
FileSize
534 bytes

potential patch file attached

dsjordan’s picture

Assigned: dsjordan » Unassigned
nedjo’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

mpotter’s picture

Status: Reviewed & tested by the community » Needs review

So wait, this doesn't make sense to me.

Where is the "assignment.alter" coming from? That isn't a plugin provided by Features. It is something else? The UUid for config is added by core when config is exported to the sync directory. Features strips that out. I don't see any config schemas in core adding those keys, so I don't understand why Features would need to add them to our schema.

I think this needs more investigation.

@Nedjo: am I missing something since you said this looks good?

nedjo’s picture

Status: Needs review » Needs work

@mpotter: these are coming from the 'alter' features assignment plugin I added in #2599278: Move export processing to a configurable plugin. That plugin adds configuration settings 'uuid', 'core', and 'user_permissions', but I neglected to update the features bundle schema accordingly.

But looking again at the patch, we shouldn't be adding these properties directly to features.assignment.*. Instead, we need a new section for features.assignment.alter.

Grimreaper’s picture

Version: 8.x-3.4 » 8.x-3.x-dev
Status: Needs work » Needs review
FileSize
3.43 KB

Hello,

I made a patch before seing that this issue exists.

It declares the config type "features.assignment.settings" so it can be used to refactor existing assignment config and easily declare the alter assignment.

Thanks for the review.

juampynr’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and fixes the issue. I am now able to run JavaScript tests without getting this error. The tests use a module that has exported settings via Features.

  • mpotter committed 35f1cd8 on 8.x-3.x authored by Grimreaper
    Issue #2858909 by dsjordan, Grimreaper: Features 3.4 causes test...
mpotter’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 35f1cd8. The addition of features.assignment.settings to remove all the dup code is great, thanks!

Grimreaper’s picture

Thanks for the commit :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.