Line 157 of yoast_seo/src/YoastSeoManager.php calls Views, but yoast_seo.info.yml doesn't declare a dependency on Views. This causes a fatal error if you attempt to install Yoast on a site without Views installed.

CommentFileSizeAuthor
#5 yoast_seo-2858496-5.patch297 bytesDane Powell
yoast_seo.patch241 bytessamuelj13
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

samuelj13 created an issue. See original summary.

Dane Powell’s picture

Dane Powell CreditAttribution: Dane Powell at Acquia commented
Title: Add Views module to Dependencies » Undeclared dependency on Views causes fatal errors
Issue summary: View changes

@samuelj13 thanks a lot for submitting this patch. Typically once you submit a patch you change the status to "needs review" so that other community members can review it. See the documentation on submitting patches.

I'll also update the issue summary and title to provide a little more details.

Dane Powell’s picture

Dane Powell CreditAttribution: Dane Powell at Acquia commented
Status: Active » Needs review
Dane Powell’s picture

Dane Powell CreditAttribution: Dane Powell at Acquia commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

Patch looks good to me so moving this to RTBC

Dane Powell’s picture

Dane Powell CreditAttribution: Dane Powell at Acquia commented
FileSize
yoast_seo-2858496-5.patch297 bytes

Here's the same patch as #0 that should apply cleanly on composer-based installs (see #2858245: Patching .info.yml files)

robertragas’s picture

robertragas CreditAttribution: robertragas commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.