Formatting detail for consistency: I think the number of line breaks before the default signature "-- [site:name] team" should be the same for all user e-mails.

The one for "register_pending_approval" has 3 line breaks where all the others have 2 only.

CommentFileSizeAuthor
#3 user_email_line_breaks-d7.x-2858455-3.patch596 bytespacproduct
#2 user_email_line_breaks-2858455-2.patch1.65 KBpacproduct
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pacproduct created an issue. See original summary.

pacproduct’s picture

pacproduct CreditAttribution: pacproduct commented
Status: Active » Needs review
FileSize
user_email_line_breaks-2858455-2.patch1.65 KB

Attached file addresses this for Drupal 8.4.x-dev

pacproduct’s picture

pacproduct CreditAttribution: pacproduct commented
FileSize
user_email_line_breaks-d7.x-2858455-3.patch596 bytes

Here is the same thing, for Drupal 7.x-dev

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges at Makina Corpus commented
Component: user.module » user interface text
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Component: user interface text » user.module

This is the user module.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

sim_1’s picture

sim_1
she/her
CreditAttribution: sim_1 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Tested the d8 patch and it worked. Tentatively marking as reviewed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +String change in 8.6.0

As a string change this can't go in 8.5.x. Also the policy now for Drupal 7 backports is to open a new issue. I also pondered the existing site issue - ie should we have an upgrade path. I think not because it is possible that someone has changed all the others from \n\n-- [site:name] team to \n\n\n-- [site:name] team - obviously very unlikely but possible.

Committed d2a14db and pushed to 8.6.x. Thanks!

  • alexpott committed d2a14db on 8.6.x 
    Issue #2858455 by pacproduct: Number of line breaks consistency in user...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.