Problem/Motivation

It is currently not possible to translate a node and assign different translations of that node to different menus, such as when you have a "Main menu (English)" menu and a "Main menu (French)" menu that are not translations of each other, with different structures.

Proposed resolution

Make the fields translatable.

Remaining tasks

Decide on an approach
Patch
Tests
Review

User interface changes

Fields are available for translation now ("menu name" and "parent plugin ID" should probably be combined into "parent" in the UI):

API changes

Data model changes

weight, parent, menu_name fields become translatable on menu link content

CommentFileSizeAuthor
#10 2858201-10.patch6.75 KBstefan.r
#7 2858201-7.patch6.76 KBstefan.r
#6 2858201-6.patch7.03 KBstefan.r
#5 2858201-5.patch1.7 KBjofitz
#2 2858201-1.patch1.7 KBstefan.r
Screen Shot 2017-03-06 at 19.25.56.png75.24 KBstefan.r
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stefan.r created an issue. See original summary.

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Status: Active » Needs review
FileSize
2858201-1.patch1.7 KB

I wonder if we should also make some of the other fields translatable (link, external, enabled, ..)

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented

Looks good, glad it worked.

I wonder if there's a reason not to make everything translatable.

Status: Needs review » Needs work

The last submitted patch, 2: 2858201-1.patch, failed testing.

jofitz’s picture

jofitz CreditAttribution: jofitz at ComputerMinds commented
Status: Needs work » Needs review
FileSize
2858201-5.patch1.7 KB

Re-rolled.

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Issue tags: -Needs tests
FileSize
2858201-6.patch7.03 KB

Adding some tests and an update hook

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
FileSize
2858201-7.patch6.76 KB

The last submitted patch, 6: 2858201-6.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 7: 2858201-7.patch, failed testing.

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Status: Needs work » Needs review
FileSize
2858201-10.patch6.75 KB

This doesn't update menu_tree correctly yet, only data from whichever translation was last saved is stored currently

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented 
+++ b/core/modules/menu_ui/src/Tests/MenuNodeTest.php
@@ -311,31 +321,48 @@ public function testMultilingualMenuNodeFormWidget() {
+
+    // Assert that the original link exists in the frontend.
+    $this->drupalGet('node/' . $node->id(), array('language' => $languages[$langcodes[0]]));
+    $this->assertLink($node_title);
...
+    // Assert that the translated link exists in the frontend.
+    $this->drupalGet('node/' . $node->id(), array('language' => $languages[$langcodes[1]]));
+    $this->assertLink($translated_node_title);

Is it just me that this test coverage is a bit weak? Can't we ensure that the link is actually available in the two separate selected menus?

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented

Discussing this on IRC with @pwolanin, this patch is probably not the right approach.

He's suggesting a menu link field (#2315773: Create a menu link field type/widget/formatter) and patching the node menu widget to allow for a separate menu link per translation (rather than translating menu links themselves).

pwolanin’s picture

pwolanin CreditAttribution: pwolanin as a volunteer and commented

Yes, we should close this issue I think

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Status: Needs review » Closed (won't fix)

We're working on a solution in #2859270: Cleanup the entity <-> menu link integration