Removing the variable is not used.

CommentFileSizeAuthor
#2 shortcode_asciinema-2858038-2.patch586 bytespifagor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pifagor created an issue. See original summary.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor commented
Version: 8.x-1.x-dev » 8.x-1.0-alpha1
Assigned: pifagor » Unassigned
Status: Needs work » Needs review
FileSize
shortcode_asciinema-2858038-2.patch586 bytes

  • grasmash committed 7a75131 on 8.x-1.x authored by pifagor 
    Issue #2858038 by pifagor: Removing the variable is not used
grasmash’s picture

grasmash CreditAttribution: grasmash commented
Status: Needs review » Fixed

Thanks!

grasmash’s picture

grasmash CreditAttribution: grasmash commented

Reverting this commit. It introduced a bug.

[24-Mar-2017 16:37:13 UTC] PHP Fatal error: Declaration of Drupal\shortcode_asciinema\Plugin\Shortcode\AsciinemaShortcode::process() must be compatible with Drupal\shortcode\Plugin\ShortcodeInterface::process($attributes, $text, $langcode = Drupal\Core\Language\Language::LANGCODE_NOT_SPECIFIED) in docroot/modules/contrib/shortcode_asciinema/src/Plugin/Shortcode/AsciinemaShortcode.php on line 21 request_id="586e8501-602f-451a-a5a6-d9c1034122e1"

  • grasmash committed 594fdac on 8.x-1.x 
    Revert "Issue #2858038 by pifagor: Removing the variable is not used"...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community commented