Problem/Motivation
This issue came up after updating the module to the latest version. It seems that the *Redirects 404* module registers a logger factory service (\Drupal\redirect_404\Render\Redirect404LogSuppressor) that overrides the default service (Drupal\Core\Logger\LoggerChannelFactory). When applying the database updates or trying to access any of the administrative pages it triggers a Fatal error, similar to the one in https://www.drupal.org/node/2853175
Proposed resolution
Change all calls including Drupal\Core\Logger\LoggerChannelFactory to use Drupal\Core\Logger\LoggerChannelFactoryInterface instead
Remaining tasks
The patch is ready for review.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | fatal_error_invalid-2857762-11.patch | 14.18 KB | scor |
| #10 | fatal_error_invalid-2857762-10.patch | 14.19 KB | john cook |
| #5 | fatal_error_invalid-2857762-5.patch | 13.76 KB | john cook |
| #3 | acquia_contenthub-fix_logger_and_config_interface-2857762-3.patch | 13.68 KB | ericmaster |
Comments
Comment #2
it-cruSame problem here together with redirect module. I've added also change from ConfigFactory to ConfigFactoryInterface to existing patch.
Comment #3
ericmaster commentedRe-rolled patch for 8.x-1.7
Comment #5
john cook commentedI was having problems applying the patch from #3 against version 8.x-1.8, so I've rerolled that patch.
Comment #6
nidaismailshah commentedI got this issue when updating redirect module. I applied this patch and it works for me well on 8.x-1.8
Marking as RTBC but not sure if this needs to be raised against 8.x-1.9
Comment #7
nidaismailshah commentedin favor of #6
Comment #8
Phil Wolstenholme commentedThe patch needs rerolling for 8.x-1.9: https://www.drupal.org/patch/reroll
Comment #9
john cook commentedAdded needs reroll tag.
Comment #10
john cook commentedRerolled #5 against dev.
Comment #11
scor commentedrerolling
Comment #13
scor commentedThanks everyone for contributing to this patch!