Problem/Motivation

This issue came up after updating the module to the latest version. It seems that the *Redirects 404* module registers a logger factory service (\Drupal\redirect_404\Render\Redirect404LogSuppressor) that overrides the default service (Drupal\Core\Logger\LoggerChannelFactory). When applying the database updates or trying to access any of the administrative pages it triggers a Fatal error, similar to the one in https://www.drupal.org/node/2853175

Proposed resolution

Change all calls including Drupal\Core\Logger\LoggerChannelFactory to use Drupal\Core\Logger\LoggerChannelFactoryInterface instead

Remaining tasks

The patch is ready for review.

Comments

Ericmaster created an issue. See original summary.

it-cru’s picture

Status: Active » Needs review
StatusFileSize
new17.75 KB

Same problem here together with redirect module. I've added also change from ConfigFactory to ConfigFactoryInterface to existing patch.

ericmaster’s picture

Version: 8.x-1.6 » 8.x-1.7
StatusFileSize
new13.68 KB

Re-rolled patch for 8.x-1.7

john cook’s picture

Version: 8.x-1.7 » 8.x-1.8
StatusFileSize
new13.76 KB

I was having problems applying the patch from #3 against version 8.x-1.8, so I've rerolled that patch.

nidaismailshah’s picture

I got this issue when updating redirect module. I applied this patch and it works for me well on 8.x-1.8

Marking as RTBC but not sure if this needs to be raised against 8.x-1.9

nidaismailshah’s picture

Status: Needs review » Reviewed & tested by the community

in favor of #6

Phil Wolstenholme’s picture

Version: 8.x-1.8 » 8.x-1.9
Status: Reviewed & tested by the community » Needs work

The patch needs rerolling for 8.x-1.9: https://www.drupal.org/patch/reroll

john cook’s picture

Issue tags: +Needs reroll

Added needs reroll tag.

john cook’s picture

Version: 8.x-1.9 » 8.x-1.x-dev
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new14.19 KB

Rerolled #5 against dev.

scor’s picture

StatusFileSize
new14.18 KB

rerolling

  • scor committed 21b863f on 8.x-1.x authored by Ericmaster
    Issue #2857762 by Ericmaster, John Cook, scor, IT-Cru: Fatal Error,...
scor’s picture

Status: Needs review » Fixed

Thanks everyone for contributing to this patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.