CommentFileSizeAuthor
#10 patch-2857523-remove-new-line-at-eof-in-redirect-info-10.patch225 bytespriyanka.attarde
#5 2857523-remove-new-line-at-eof-in-redirect-info-5.patch219 bytespriyanka.attarde
#4 patch-2857523-4.patch269 bytesrpayanm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Title: Remove new line at EOF » Remove new line at EOF in redirect.info
swati.nuna’s picture

swati.nuna CreditAttribution: swati.nuna as a volunteer and at InfoBeans Technologies Limited commented
Assigned: Unassigned » swati.nuna
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm at SeeD EM commented
Assigned: swati.nuna » Unassigned
Status: Active » Needs review
FileSize
patch-2857523-4.patch269 bytes
priyanka.attarde’s picture

priyanka.attarde CreditAttribution: priyanka.attarde as a volunteer and at InfoBeans Technologies Limited commented
FileSize
2857523-remove-new-line-at-eof-in-redirect-info-5.patch219 bytes

@rpayanm, issue is reported for 7.x-1.0-rc3. Given patch #4 is for Drupal 8 version.

Please find the patch for Drupal 7.x-1.0-rc3 version.

swati.nuna’s picture

swati.nuna CreditAttribution: swati.nuna as a volunteer and at InfoBeans Technologies Limited commented
Status: Needs review » Reviewed & tested by the community

Hi,

Apply patch working as cleanly.
Change the status to RTBC.

The last submitted patch, 4: patch-2857523-4.patch, failed testing.

The last submitted patch, 4: patch-2857523-4.patch, failed testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 2857523-remove-new-line-at-eof-in-redirect-info-5.patch, failed testing.

priyanka.attarde’s picture

priyanka.attarde CreditAttribution: priyanka.attarde as a volunteer and at InfoBeans Technologies Limited commented
Status: Needs work » Needs review
FileSize
patch-2857523-remove-new-line-at-eof-in-redirect-info-10.patch225 bytes

Attached new patch.

Status: Needs review » Needs work

The last submitted patch, 10: patch-2857523-remove-new-line-at-eof-in-redirect-info-10.patch, failed testing.

jansete’s picture

jansete CreditAttribution: jansete commented
Status: Needs work » Closed (works as designed)

It's all fine in 7.x-1.x-dev branch, nothing to change, it works as designed.

When Drupal make the package of the release add two lines at the end you can see a core module if you download drupal with download link, and then compare if you download drupal with git.

Git, all correct, 1 line in the end.
Downloaded with tar and other package link, 2 lines, all correct. (2 lines is part of the package process).